Skip to content

Gh1363 open street map access #1374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kebarr wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Gh1363 open street map access #1374

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a902b7c
changed default to get around open streetmap issue
Nov 10, 2026
cb91bcf
update layout in plot_sample_location_mapbox
Nov 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion malariagen_data/anoph/map_params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ def items(self):
""",
]

basemap_default: basemap = "mapnik"
basemap_default: basemap = "worldstreetmap"

height: TypeAlias = Annotated[
Union[int, str], "Height of the map in pixels (px) or other units."
Expand Down
6 changes: 5 additions & 1 deletion malariagen_data/anoph/sample_metadata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1049,6 +1049,10 @@ def plot_samples_interactive_map(
if isinstance(width, int):
width = f"{width}px"

if basemap in ["mapnik", "positron"]:
raise ValueError(
f"Basemap {basemap!r} is not currently supported for interactive maps; try one of {['natgeoworldmap', 'opentopomap', 'satellite', 'worldimagery', 'worldstreetmap', 'worldtopomap']}"
)
# Load sample metadata.
df_samples = self.sample_metadata(
sample_sets=sample_sets,
Expand Down Expand Up @@ -1880,7 +1884,7 @@ def plot_sample_location_mapbox(

# Set the size of the markers.
fig.update_traces(marker=dict(size=marker_size))

fig.update_layout(map_style="carto-positron")
if show: # pragma: no cover
fig.show(renderer=renderer)
return fig
Expand Down
Loading