Repository navigation
Conversation
This was referenced Mar 3, 2024
Pull Request Test Coverage Report for Build 8131673125Details
💛 - Coveralls |
aaqilniz
force-pushed
the
feat/strict-mode
branch
from
March 3, 2024 16:51
ebd9490 to
6dbbbc6
Compare
aaqilniz
marked this pull request as ready for review
April 13, 2024 17:03
aaqilniz
marked this pull request as draft
October 25, 2026 10:19
aaqilniz
force-pushed
the
feat/strict-mode
branch
2 times, most recently
from
October 25, 2026 15:52
7afda97 to
a9d261b
Compare
Signed-off-by: Muhammad Aaqil <aaqilcs102@gmail.com>
aaqilniz
force-pushed
the
feat/strict-mode
branch
from
October 25, 2026 15:57
a9d261b to
d86090e
Compare
aaqilniz
marked this pull request as ready for review
October 25, 2026 15:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the base
discoverIsStrictinterface and abstractbuildQueryIsStrictmethod toSQLConnectorinloopback-connector, enabling SQL connectors to expose database strict-mode detection up toloopback-datasource-juggler.Purpose and Context
This is part of the cross-package effort to ensure that when a database (like MySQL) runs in strict mode, model discovery populates
jsonSchema.maxLengthalongside the top-levellengthproperty to trigger application-level validation.Key Changes
SQLConnector.prototype.discoverIsStrict()to execute strict-mode queries.SQLConnector.prototype.buildQueryIsStrict()requiring implementation by child connectors.Related Issue:
jsonSchema.maxLengthalongsidelengthto support strict-mode validation loopback-next#11869Related PRs:
Checklist
npm testpasses on your machine