Skip to content

WIP Sturm-Tarski based real_root_count tactic - #45289

Closed
paulcadman wants to merge 1 commit into
leanprover-community:masterfrom
paulcadman:sturm-tarski-real-root-count-skeleton
Closed

paulcadman wants to merge 1 commit into
leanprover-community:masterfrom
paulcadman:sturm-tarski-real-root-count-skeleton

Conversation

@paulcadman

Copy link
Copy Markdown
Contributor

@paulcadman paulcadman closed this Oct 26, 2026
@github-actions

Copy link
Copy Markdown

PR summary 2ff868e9e3

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.Tactic.RealRootCount.CoeffList (new file) 170
Mathlib.Algebra.Polynomial.Sturm.Tarski (new file) 1487
Mathlib.Algebra.Polynomial.Sturm.RootCount (new file) 1488
Mathlib.Tactic.RealRootCount.Lemmas (new file) 1492
Mathlib.Tactic.RealRootCount (new file) 1500

Declarations diff (regex)

+ RootCountCert
+ RootCountCert.card_rootSet
+ abs_lt_of_checkBound
+ add
+ chain
+ checkBound
+ checkSturm
+ derivative
+ divMod
+ eval
+ lead
+ mapLemmas
+ monomialOf
+ mul
+ neg
+ parsePoly
+ proveCardRootSet
+ provePolyEq
+ ratOf
+ rem
+ rootBound
+ rootsIn
+ sturm
+ sturmSeq_of_check
+ sturmSignVariations
+ sturm_tarski
+ sturm_tarski'
+ toReal
+ trim
+ variations
+ variations_of_check

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean -- pending)

Computed after the build finishes.


No changes to strong technical debt.

Increase in weak tech debt: (relative, absolute) = (4.00, 0.00)
Current number Change Type (weak)
5103 4 exposed public sections

Current commit 2ff868e9e3
Reference commit 6e2da0379d

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.py pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions

Copy link
Copy Markdown

🚨 PR Title Needs Formatting

Please update the title to match our commit style conventions.

Errors from script:

labels are []
error: the PR title does not contain a colon
Details on the required title format

The title should fit the following format:

<kind>(<optional-scope>): <subject>

<kind> is:

  • feat (feature)
  • fix (bug fix)
  • doc (documentation)
  • style (formatting, missing semicolons, ...)
  • refactor
  • test (when adding missing tests)
  • chore (maintain)
  • perf (performance improvement, optimization, ...)
  • ci (changes to continuous integration, repo automation, ...)

<optional-scope> is a name of module or a directory which contains changed modules.
This is not necessary to include, but may be useful if the <subject> is insufficient.
The Mathlib directory prefix is always omitted.
For instance, it could be

  • Data/Nat/Basic
  • Algebra/Group/Defs
  • Topology/Constructions

<subject> has the following constraints:

  • do not capitalize the first letter
  • no dot(.) at the end
  • use imperative, present tense: "change" not "changed" nor "changes"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant