Repository navigation
Conversation
Coerce single limit string or callable into a list in Limiter.__init__ for default_limits, application_limits, and in_memory_fallback. Previously, passing a single string like default_limits="1/second" caused set(default_limits) to iterate individual characters ('1', '/', ...), failing rate limit parsing and crashing at request time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When initializing
Limiterwithdefault_limits="1/second"(a string) instead of a list["1/second"],set(default_limits)iterated over individual characters of the string ('1','/','s', ...), causingLimitGroupto fail parsing the rate limit with aValueErrorduring request handling. Similarly, passing a callable raisedTypeError: 'function' object is not iterable.Changes
_normalize_limitshelper to coerce single string, bytes, callable, or sequence into a list.default_limits,application_limits, andin_memory_fallbackinLimiter.__init__.Union[Sequence[StrOrCallableStr], StrOrCallableStr].CHANGELOG.md.Fixes #239