Repository navigation
driver/mqtt: really support MQTT auth for TasmotaPowerDriver - #2012
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2012 +/- ##
========================================
- Coverage 62.7% 62.7% -0.1%
========================================
Files 190 190
Lines 15447 15448 +1
========================================
Hits 9697 9697
- Misses 5750 5751 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
Emantor
reviewed
Oct 23, 2026
Emantor
approved these changes
Oct 23, 2026
Commit 022f552 ("resource/mqtt: add optional username/password for MQTT authentication") added optional MQTT authentication support, but TasmotaPowerDriver uses does not use the MQTT connection of MQTTManager as it has custom on_connect / on_message handlers, so add the username/password for the TasmotaPowerDriver connection as well. With this fixed, there are now two calls to client.username_pw_set() (from MQTTManager AND TasmotaPowerDriver), so adjust test_tasmota.py to allow that. Signed-off-by: Peter Korsgaard <peter@korsgaard.com> [rouven.czerwinski@linaro.org: fixed commit message typo] Signed-off-by: Rouven Czerwinski <rouven.czerwinski@linaro.org>
Emantor
force-pushed
the
tasmota-mqtt-auth
branch
from
October 23, 2026 17:17
317f5f9 to
cb09439
Compare
Emantor
enabled auto-merge
October 23, 2026 17:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 022f552 ("resource/mqtt: add optional username/password for MQTT authentication") added optional MQTT authentication support, but TasmotaPowerDriver uses does not use the MQTT connection of MQTTManager as it has custon on_connect / on_message handlers, so add the username/password for the TasmotaPowerDriver connection as well.
With this fixed, there are now two calls to client.username_pw_set() (from MQTTManager AND TasmotaPowerDriver), so adjust test_tasmota.py to allow that.