Repository navigation
Propagate client identity to exporter - #1939
Open
asher-pem-arm wants to merge 2 commits into
Open
asher-pem-arm wants to merge 2 commits into
asher-pem-arm wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1939 +/- ##
========================================
- Coverage 62.8% 62.8% -0.1%
========================================
Files 188 190 +2
Lines 15348 15457 +109
========================================
+ Hits 9640 9708 +68
- Misses 5708 5749 +41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
5 of 7 tasks
asher-pem-arm
force-pushed
the
propagate-client-identity-to-exporter
branch
from
September 3, 2026 09:18
5e101e9 to
e49e221
Compare
asher-pem-arm
force-pushed
the
propagate-client-identity-to-exporter
branch
from
October 13, 2026 10:45
e49e221 to
8ed5bb1
Compare
Contributor
Author
Emantor
reviewed
Oct 14, 2026
Member
|
Except for the comment by @Emantor, this looks good to me. |
Emantor
previously approved these changes
Oct 21, 2026
ozan956
suggested changes
Oct 22, 2026
Comment on lines
-1120
to
+1135
| f"Resource {group_name}/{resource_name} is already acquired by {resource.acquired}" | ||
| f"Resource {group_name}/{resource_name} is already in use by {resource.acquired}" |
Member
There was a problem hiding this comment.
Why you are changing this? Whats the difference between "acquired" and "in use"?
Contributor
Author
There was a problem hiding this comment.
this was a small but useful wording as part of future changes in which we can allow both acquire and lease (or similar), hopefully as part of #1884
Add acquirer_identity to ExporterSetAcquiredRequest and regenerate its Python bindings so exporters can identify the client behind resource acquisition and release commands. Send the place owner's identity on acquisition. For releases, use the request's metadata identity or fall back to the legacy client session. This records the releasing caller even when kicking another user's place. Log the identity after successful acquisition or release. Keep identity optional for callers without metadata or a client session, and for internal cleanup. Send an empty identity in those cases so existing release clients continue to work. The added protobuf field is compatible with older coordinators and exporters. Signed-off-by: Asher Pemberton <asher.pemberton@arm.com> Reviewed-by: Asher Pemberton <asher.pemberton@arm.com> # gatekeeper Co-authored-by: Luke Beardsmore <luke.beardsmore2@arm.com> Co-authored-by: Idan Saadon <idan.saadon@arm.com>
Replace the identity string at field 4 of ExporterSetAcquiredRequest with ClientIdentity.id, allowing more identity fields to be added in future. Update coordinator and exporter accesses and regenerate the Python bindings, preserving the existing identity values and log messages. Signed-off-by: Asher Pemberton <asher.pemberton@arm.com> Reviewed-by: Asher Pemberton <asher.pemberton@arm.com> # gatekeeper Co-authored-by: Luke Beardsmore <luke.beardsmore2@arm.com> Co-authored-by: Idan Saadon <idan.saadon@arm.com>
asher-pem-arm
force-pushed
the
propagate-client-identity-to-exporter
branch
from
October 22, 2026 10:46
f39b458 to
af11bd4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Exporters currently receive only the logical place name when acquiring or leasing a resource. They cannot identify which client initiated the operation in exporter-local logs. This improves per-resource diagnostics and traceability on distributed exporter hosts. The identity is used only for logging; authorization and resource ownership semantics are unchanged.
This PR:
Builds on:
#1886
Checklist