Skip to content

fix: honor options.contextPointer in QuickJSAsyncRuntime.newContext #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xfy2412 wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −1
Open

fix: honor options.contextPointer in QuickJSAsyncRuntime.newContext #272

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/quickjs-emscripten-core/src/runtime-asyncify.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,12 @@ export class QuickJSAsyncRuntime extends QuickJSRuntime {
override newContext(options: ContextOptions = {}): QuickJSAsyncContext {
const intrinsics = intrinsicsToFlags(options.intrinsics)
const ctx = new Lifetime(
this.ffi.QTS_NewContext(this.rt.value, intrinsics),
// Honor options.contextPointer like the base runtime does (runtime.ts): callers pass it to
// *wrap* an existing context (the module loader and executePendingJobs both use
// `this.contextMap.get(ptr) ?? this.newContext({ contextPointer: ptr })`). Ignoring it
// creates a brand new engine context instead of wrapping the one the caller asked for, and
// nothing owns that new context, so it leaks until JS_FreeRuntime asserts.
options.contextPointer || this.ffi.QTS_NewContext(this.rt.value, intrinsics),
undefined,
(ctx_ptr) => {
this.contextMap.delete(ctx_ptr)
Expand Down