Repository navigation
Conversation
| }) | ||
| } | ||
|
|
||
| pub async fn get_op_heads_without_reconciliation( |
There was a problem hiding this comment.
Currently unused, right? Or did I miss something?
There was a problem hiding this comment.
Correct, currently unused but useful in the future (for read only checking for errors, visibility into repo state without modification, etc)
Added a comment clarifying that it is unused
There was a problem hiding this comment.
At Google we have a get_op_heads_without_reconciliation in our internal OpHeadsStore implementation that we use for a few commands that should modify repo state, for example for filing bug reports.
This LGTM.
4e3277e to
22e1a37
Compare
| }) | ||
| } | ||
|
|
||
| pub async fn get_op_heads_without_reconciliation( |
There was a problem hiding this comment.
At Google we have a get_op_heads_without_reconciliation in our internal OpHeadsStore implementation that we use for a few commands that should modify repo state, for example for filing bug reports.
This LGTM.
22e1a37 to
26d5ce2
Compare
Add get_op_heads_with_reconciliation and get_op_heads_without_reconciliation functions. The latter function (without) does not perform a reconciliation operation and just does a Store read to return the heads that are present. The former function just makes an RPC call to the ReconcileOpHeads RPC, which performs reconciliation and returns the resulting resolved head. The vast majority of get_op_heads calls will be made with reconciliation, as jj commands expect a singular op head per repository.
26d5ce2 to
d556734
Compare
lib: add functions for getting op heads
Add get_op_heads_with_reconciliation and get_op_heads_without_reconciliation functions. The latter function (without) does not perform a reconciliation operation and just does a Store read to return the heads that are present. The former function just makes an RPC call to the ReconcileOpHeads RPC, which performs reconciliation and returns the resulting resolved head. The vast majority of get_op_heads calls will be made with reconciliation, as jj commands expect a singular op head per repository.