Add status query managers that inherit methods of a custom queryset - #487
Open
EliasCampos wants to merge 1 commit into
Open
EliasCampos wants to merge 1 commit into
EliasCampos wants to merge 1 commit into
Conversation
Codecov Report
@@ Coverage Diff @@
## master #487 +/- ##
=========================================
Coverage ? 94.58%
=========================================
Files ? 6
Lines ? 757
Branches ? 0
=========================================
Hits ? 716
Misses ? 41
Partials ? 0
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Please see #486
Solution
In
add_status_query_managerssignal handler, add creation of manager class, that inheritsQueryManagerand takes methods of a queryset, returned by.get_queryset()method of a default manager. Status managers, added to a model, are instances of the created manager.Commandments
CHANGES.rstfile to describe the changes, and quote according issue withGH-<issue_number>.