Skip to content

Timeline command components crash on unexpected payload shapes #1600

Description

@joshuayoes

Several timeline command components assume specific payload shapes and will throw if the data doesn't match. An error boundary was added in #1598 to prevent these from crashing the app, but the components themselves should add defensive guards.

Vulnerable components:

  • AsyncStorageMutationCommand — payload.data.key accessed without null check
  • ApiResponseCommand — payload.request and payload.response destructured without null checks
  • StateValuesChangeCommand — insufficient type checking before Object.keys()
  • BenchmarkReportCommand — payload.steps array accessed without validation, crashes on empty array
  • SagaTaskCompleteCommand/Stateless — payload.children.length and .map() without array check

These were safe when the only payload source was the client SDK, but with the MCP server (#1598) there's now a second source of commands that may produce different shapes.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions