Skip to content

ok: handle already-parsed flashvars.metadata - #1625

Open
xawarrior wants to merge 1 commit into
imputnet:mainfrom
xawarrior:ok-metadata-object
Open

xawarrior wants to merge 1 commit into
imputnet:mainfrom
xawarrior:ok-metadata-object

Conversation

@xawarrior

Copy link
Copy Markdown

On main, the official ok/regular video test fails with error.api.fetch.critical. The ok.ru page now has flashvars.metadata as an object, and ok.js calls JSON.parse on it, which throws "[object Object]" is not valid JSON.

This parses the value only when it is still a string, so the old string format keeps working.

Tested locally on one public video: the official ok test passes, and a ranged request to the returned stream gives 206 video/mp4. I did not test the full local HTTP tunnel path or other ok.ru video types.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant