Repository navigation
Conversation
voropaevv
marked this pull request as ready for review
November 11, 2026 02:57
Merge main and route mapped sequences through the validated PreTokens factory. Preserve private construction, mapped-text lifetimes and ByteMap length errors. Cover an empty prefix as well as existing split sequences.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2670.
The FalconMamba tokenizer runs
DigitsandSpliton the output ofByteLevel. Preserve the byte mapping at that point in the converted sequence and pass the resulting spans to character BPE. TerminalByteLevelkeeps its existing fused path.The regression checks a split inside the mapped bytes of
β, both regex settings, and a canonical JSON round trip. With the original FalconMamba tokenizer,compile().encode("Hello\tworld 123").idsreturns[9856, 192, 9091, 204, 10963], matching 0.23.3.Checked the Rust workspace, Clippy, the local Python suite, and 566 FalconMamba inputs against 0.23.3 for token IDs and decoded text.