A benchmark example may carry its own cutoff - #99
Open
tarekziade wants to merge 1 commit into
Open
tarekziade wants to merge 1 commit into
tarekziade wants to merge 1 commit into
Conversation
A run-level --before puts one instant on every example in a set. That is right for a smoke test and wrong for a set whose examples come from different points in history: twenty examples drawn from twenty issues have twenty cutoffs, and a flag holds exactly one. Example gains `before` (ISO 8601, timezone-aware or refused -- a cutoff with no zone is a different instant depending on who runs the set) and `exclude`, both defaulting to nothing, so every existing frozen set stays loadable and every untimed run is unchanged. IndexSystem.window() narrows an example's window against the run's. An example may narrow the run and can never widen it -- the same rule, and the same argument, as the AsOf daemon pin: a bound the run was started with is not something the data it reads may lift. Exclusions are the union, because neither side is entitled to readmit the other's withheld thread. The signal post-filter is now pinned per example rather than per run: it re-derives each hit thread's signals as of a cutoff, so a run-level one would size the leak against the wrong instant for every example carrying its own. 20 tests. Suite 1326 passed, 4 skipped, 2 xfailed on both dialects. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A run-level
--beforeputs one instant on every example in a set. That isright for a smoke test and wrong for a set whose examples come from different
points in history: twenty examples drawn from twenty issues have twenty
cutoffs, and a flag holds exactly one.
Examplegainsbefore(ISO 8601, timezone-aware or refused — a cutoff withno zone is a different instant depending on who runs the set) and
exclude,both defaulting to nothing, so every existing frozen set stays loadable and
every untimed run is unchanged.
IndexSystem.window()narrows an example's window against the run's. Anexample may narrow the run and can never widen it — the same rule, and the
same argument, as the
AsOfdaemon pin: a bound the run was started with isnot something the data it reads may lift. Exclusions are the union, because
neither side is entitled to readmit the other's withheld thread.
The signal post-filter is now pinned per example rather than per run: it
re-derives each hit thread's signals as of a cutoff, so a run-level one would
size the leak against the wrong instant for every example carrying its own.
20 tests. Suite 1326 passed, 4 skipped, 2 xfailed on both dialects.
🤖 Generated with Claude Code