Repository navigation
fix: Fix default RNG synchronization for ditribution #15141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JingyaHuang
wants to merge
16
commits into
huggingface:main
Choose a base branch
from
JingyaHuang:sync-parallel-rng-seed
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+230
−1
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
e88275f
fix: Fix default RNG synchronization for ditribution
JingyaHuang 67bb0dd
Merge branch 'main' into sync-parallel-rng-seed
JingyaHuang dbd5332
fix: use broadcast for just one rank instead of all gather all ranks
JingyaHuang f6ad3c8
removal: simplify the docstring
JingyaHuang 27d63cd
test: seeds matching test
JingyaHuang a94cb28
test: improve, get into existed tests
JingyaHuang d18bbda
Merge branch 'main' into sync-parallel-rng-seed
JingyaHuang 044e06a
fix: sync default RNG only within the parallel mesh
JingyaHuang 23a0ff3
Merge branch 'main' into sync-parallel-rng-seed
JingyaHuang f3cb490
test: move parallel RNG sync checks into a standalone test
JingyaHuang 021aef5
Merge branch 'sync-parallel-rng-seed' of github.com:JingyaHuang/diffu…
JingyaHuang b4730f8
Merge branch 'main' into sync-parallel-rng-seed
JingyaHuang a0330c8
review: test RNG sync against non-parallel run and from_pretrained
JingyaHuang afe646e
generalize the test case for sync rng for all supported models.
sayakpaul c90268e
Merge branch 'main' into sync-parallel-rng-seed
JingyaHuang fe44de2
Merge pull request #3 from huggingface/generalize-parallel-rng-sync-t…
JingyaHuang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.