Skip to content

Adopt 43 open upstream platform.ui fixes and enhancements (JFace, workbench, Find/Replace, CSS, code minings) - #77

Merged
hsoliwal merged 96 commits into
masterfrom
m3/upstream-prs-20261116
Nov 16, 2026
Merged

hsoliwal merged 96 commits into
masterfrom
m3/upstream-prs-20261116

Conversation

@hsoliwal

Copy link
Copy Markdown
Owner

Brings 43 open upstream eclipse.platform.ui PRs into the fork. Each one is ready for review upstream (not a draft) and green on upstream CI.

Highlights:

Where an upstream PR met fork work, each conflict was resolved by reading both sides:

Verification on 97ad421:

  • Tree loss guard: no fork path dropped, and every upstream PR path is present. The only differences from upstream PR content are the four _ -> unused renames, each confirmed to be exactly that recipe.
  • All 152 changed Java files parse at Java 21.

mehmet-karaman and others added 30 commits October 20, 2025 11:55
- added synchronize block to methods in AnnotationModel, wherever reads
/ writes could happen in multiple threads.
- changed execution order, to be able to synchronize only necessary code
blocks.

Co-authored-by: Andrey Loskutov <loskutov@gmx.de>
Co-authored-by: marcushoepfner <marcus.hoepfner@sap.com>
> did you consider putting this in a method and provide some java doc for the method. With that:
> 
https://github.com/eclipse-platform/eclipse.platform.ui/pull/3169/files/6841a0ef260ff65316607a1d4d2b6617b8dc637b#r2329939384

> * very detailed math code is hidden from the method flow (increased readability of the setOnboardingControlSize method)
> * comments can be removed and put into java doc of the new method
> 
> WDYT?
update version
Display the total number of search results in the Find/Replace overlay
if any else hide the bar
Moved debug option handling from Policy to WorkbenchPlugin,
adjusted it to use OSGI debug option handling.

Replaced standard out and log tracing in org.eclipse.ui.workbench with OSGI tracing.

Fixes: eclipse-platform#4033
Add an optional Autocomplete support in chevron popup with preference
toggle in the
eclipse Settings->Preference->General page. Introduced a new
autocomplete behavior for the chevron popup filter text. As the user
types, matching editor names are suggested and the remaining part is
auto-filled, improving navigation efficiency within the chevron pop up.

Key changes:
- Added `chevronAutocompleteBehavior()` to implement auto completion
  with suggestion.
- Retained existing `normalFilterBehavior()` for plain text filtering
incase  the user wanted to disable the auto complete feature.
- Updated `installFilter()` to switch between behaviors based on user
  preference
- Added `isAutocompleteEnabled()` method to check the preference state
When hovering over a top-level project node in the tree layout, an
option appears showing expand or collapse based on the node's current
state. This is to individually expand or collapse tree parent items.
Selecting everything with Ctrl+A in the Project Explorer also selects
files and non-resource elements such as working set headers. The
provider enablement required every element to be a resource or working
set, and the actions required every selected resource to be a project,
so Open Project and Close Project disappeared for such selections.

The provider is now always enabled and only skips selections that
contain no resource or working set at all. The project actions enable
when the selection contains a project and run on the projects only.
Close Unrelated Projects no longer keeps the targets of an earlier
selection when the new one has no resources, and Refresh is left out
for elements it cannot refresh.

Fixes eclipse-platform#3790

Assisted-by: multiple AI agents and layers of automated tooling 🤖
The preview file count depended on the first child's shape and could
change when sibling groups were reordered. Traverse composite children
and identify distinct workspace files from leaf change metadata instead.
Handle opaque multi-file changes without exposing selectable children,
and retain the existing selection-independent overview semantics.

Add 13 JUnit regression tests to the existing LTK core test suite.

Assisted-by: OpenAI ChatGPT
Signed-off-by: Carsten Hammer <carsten.hammer@t-online.de>
addPage(IFormPage) went through MultiPageEditorPart.addPage(Control),
which calls the overridden addPage(int, Control) and so registered the
page control (null for a lazily created page) in 'pages' before
configurePage registered the form page itself. The page table then held
more entries than tabs, kept disposed controls after removePage, and a
lazily added control page could be skipped, leaving later form pages
with wrong indices.

Add the tab through the superclass directly, as addPage(int, IFormPage)
already does, so each form page is registered once.

Fixes eclipse-platform#4107
A detached window is created as a child shell of the workbench window
shell. The window manager keeps a child window with its owner, so
clicking in a detached view that was moved over another application
(e.g. on a second monitor) also brings the whole workbench window to the
front, over that application.

WBWRenderer already creates a top level shell for a window tagged with
IPresentationEngine.WINDOW_TOP_LEVEL. Add the DETACHED_WINDOWS_TOP_LEVEL
preference (node org.eclipse.e4.ui.workbench.renderers.swt, default
false) that does the same for all detached windows, and a check box for
it in General > Appearance.

A top level shell has its own task bar entry, so a detached window made
top level by the preference:
- can be minimized (SWT.MIN, unless a style override is set),
- has the label of the part it shows as title when the window has no
  label of its own, instead of an empty title.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Feo5dzUJyYJAvWuN78uu2X
Collect all matches first, then replace from last to first so patterns
like "^ " with an empty replacement remove only one leading space per
line instead of all leading spaces.

Fixes eclipse-platform#2820

Signed-off-by: Edward Lo <ed700a@gmail.com>
FindReplaceDocumentAdapter returns no match when group().isEmpty(), so
bare "^" never finds. Keep the ^[space] regression for issue 2820.
FindReplaceDocumentAdapter#replace() does not take an offset: it uses the
matcher's current match and expands $n from it. Collecting all matches
before replacing leaves that matcher exhausted, so each match has to be
re-established before it is replaced - without the re-selection every
replacement fails.

The additional comparison of the re-selected offset against the stored one
was defensive only. It never triggered: matches are replaced last to first,
so the text of every pending match is unchanged and a forward search from
its offset necessarily returns the same offset. Being unreachable, it also
cannot be covered by a test. Drop it and document why the re-selection
itself is required instead.

Also let selectAll() reuse findAllMatches() rather than duplicating the
same match walk, as raised in review.

Add regression tests for re-matching during replace all: the anchor cases
fail on the previous implementation, while the group-expansion case pins
the re-selection requirement (it fails if the re-selection is removed).
replaceSelection() does not take an offset: it reads the adapter's current
match and expands $n from it. Document this on the findAndSelect(match.x)
call so the necessity of the re-selection is clear, following up on the
review discussion where the surrounding guard was removed.

Signed-off-by: Edward Lo <ed700a@gmail.com>
…lipse-platform#3639

- Remove dependency on PerformanceTestCaseJunit4.
- Migrate OpenCloseWindowTest to use PerformanceMeter directly.
- Migrate OpenClosePerspectiveTest to use PerformanceTestCaseJunit5.
- Use CloseTestWindowsExtension instead of CloseTestWindowsRule.
- Use @ParameterizedTest instead of @RunWith(Parameterized.class)

Part of the work for eclipse-platform#3639
swt-lines-visible was never undone, so a Tree or Table kept its grid
lines after the theme was switched or re-applied without that rule. The
handler now remembers the value the widget had before CSS first styled
it, and the Tree and Table element resets restore it, which keeps
lines that the application turned on itself.

Assisted-by: multiple AI agents and layers of automated tooling 🤖
…ipse-platform/eclipse.platform#2986

WizardDialog builds its shell with SWT.RESIZE but inherits isResizable() ==
false from Dialog, so hookZoomChangeListenerForDefaultSizedDialogs() installs
adaptDefaultSizeListener on every wizard. That listener calls
shell.setSize(shell.computeSize(...)), which sends the next SWT.Resize, and it
has no re-entrancy guard: whenever the computed size is not a fixed point the
listener recurses until the stack is exhausted.

Let WizardDialog report the SWT.RESIZE bit of its shell style, and make the
listener skip a nested call and a size that has not changed.

Fixes eclipse-platform/eclipse.platform#2986

Signed-off-by: Philipp SALZGEBER <Philipp.SALZGEBER@bachmann.info>
Replacing a selected occurrence of the find string could change a
different part of the document or silently do nothing. This happened
whenever the selection no longer corresponded to the target's most
recent search, e.g., after an undo restored a replaced match or after
the user manually selected another occurrence of the find string.

Replace now always acts on the selected match: if the selection is an
occurrence of the find string, exactly that occurrence is replaced;
otherwise, the next match is searched and selected as before.

The target replaces the match of its most recent search, which is
independent of the selection and outdated by any document change.
FindReplaceLogic therefore searches forward from the start of the
selection before replacing and only keeps the selection if that search
yields exactly the selected text, which makes the selection the single
source of truth for what gets replaced.

Assisted-by: Claude Opus 5.5 <noreply@anthropic.com>
Resolved by recipe: 1 file(s); provenance index and policy recomputed.
Resolved by recipe: 0 file(s); provenance index and policy recomputed.
Resolved by recipe: 1 file(s); provenance index and policy recomputed.
Resolved by recipe: 0 file(s); provenance index and policy recomputed.
Resolved by recipe: 0 file(s); provenance index and policy recomputed.
Resolved by recipe: 0 file(s); provenance index and policy recomputed.
Resolved by recipe: 0 file(s); provenance index and policy recomputed.
Resolved by recipe: 0 file(s); provenance index and policy recomputed.
Resolved by recipe: 0 file(s); provenance index and policy recomputed.
Resolved by recipe: 0 file(s); provenance index and policy recomputed.
Resolved by recipe: 0 file(s); provenance index and policy recomputed.
Resolved by recipe: 0 file(s); provenance index and policy recomputed.
Resolved by recipe: 2 file(s); provenance index and policy recomputed.
Resolved by recipe: 0 file(s); provenance index and policy recomputed.
Resolved by recipe: 1 file(s); provenance index and policy recomputed.
Resolved by recipe: 0 file(s); provenance index and policy recomputed.
Resolved by recipe: 2 file(s); provenance index and policy recomputed.
Resolved by recipe: 0 file(s); provenance index and policy recomputed.
Resolved by recipe: 1 file(s); provenance index and policy recomputed.
Resolved by recipe: 0 file(s); provenance index and policy recomputed.
Resolved by recipe: 0 file(s); provenance index and policy recomputed.
Resolved by recipe: 0 file(s); provenance index and policy recomputed.
Resolved by recipe: 1 file(s); provenance index and policy recomputed.
Resolved by recipe: 1 file(s); provenance index and policy recomputed.
Resolved by recipe: 0 file(s); provenance index and policy recomputed.
Resolved by recipe: 1 file(s); provenance index and policy recomputed.
Resolved by recipe: 1 file(s); provenance index and policy recomputed.
Resolved by recipe: 1 file(s); provenance index and policy recomputed.
Resolved by recipe: 1 file(s); provenance index and policy recomputed.
@hsoliwal
hsoliwal merged commit af1460b into master Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.