Repository navigation
Adopt 43 open upstream platform.ui fixes and enhancements (JFace, workbench, Find/Replace, CSS, code minings) - #77
Merged
Merged
Conversation
- added synchronize block to methods in AnnotationModel, wherever reads / writes could happen in multiple threads. - changed execution order, to be able to synchronize only necessary code blocks. Co-authored-by: Andrey Loskutov <loskutov@gmx.de>
Co-authored-by: marcushoepfner <marcus.hoepfner@sap.com>
> did you consider putting this in a method and provide some java doc for the method. With that: > https://github.com/eclipse-platform/eclipse.platform.ui/pull/3169/files/6841a0ef260ff65316607a1d4d2b6617b8dc637b#r2329939384 > * very detailed math code is hidden from the method flow (increased readability of the setOnboardingControlSize method) > * comments can be removed and put into java doc of the new method > > WDYT?
update version
Display the total number of search results in the Find/Replace overlay if any else hide the bar
Moved debug option handling from Policy to WorkbenchPlugin, adjusted it to use OSGI debug option handling. Replaced standard out and log tracing in org.eclipse.ui.workbench with OSGI tracing. Fixes: eclipse-platform#4033
Add an optional Autocomplete support in chevron popup with preference toggle in the eclipse Settings->Preference->General page. Introduced a new autocomplete behavior for the chevron popup filter text. As the user types, matching editor names are suggested and the remaining part is auto-filled, improving navigation efficiency within the chevron pop up. Key changes: - Added `chevronAutocompleteBehavior()` to implement auto completion with suggestion. - Retained existing `normalFilterBehavior()` for plain text filtering incase the user wanted to disable the auto complete feature. - Updated `installFilter()` to switch between behaviors based on user preference - Added `isAutocompleteEnabled()` method to check the preference state
Requires fix in platform, see eclipse-platform/eclipse.platform#2798 See eclipse-platform/eclipse.platform#2797
When hovering over a top-level project node in the tree layout, an option appears showing expand or collapse based on the node's current state. This is to individually expand or collapse tree parent items.
Selecting everything with Ctrl+A in the Project Explorer also selects files and non-resource elements such as working set headers. The provider enablement required every element to be a resource or working set, and the actions required every selected resource to be a project, so Open Project and Close Project disappeared for such selections. The provider is now always enabled and only skips selections that contain no resource or working set at all. The project actions enable when the selection contains a project and run on the projects only. Close Unrelated Projects no longer keeps the targets of an earlier selection when the new one has no resources, and Refresh is left out for elements it cannot refresh. Fixes eclipse-platform#3790 Assisted-by: multiple AI agents and layers of automated tooling 🤖
The preview file count depended on the first child's shape and could change when sibling groups were reordered. Traverse composite children and identify distinct workspace files from leaf change metadata instead. Handle opaque multi-file changes without exposing selectable children, and retain the existing selection-independent overview semantics. Add 13 JUnit regression tests to the existing LTK core test suite. Assisted-by: OpenAI ChatGPT Signed-off-by: Carsten Hammer <carsten.hammer@t-online.de>
addPage(IFormPage) went through MultiPageEditorPart.addPage(Control), which calls the overridden addPage(int, Control) and so registered the page control (null for a lazily created page) in 'pages' before configurePage registered the form page itself. The page table then held more entries than tabs, kept disposed controls after removePage, and a lazily added control page could be skipped, leaving later form pages with wrong indices. Add the tab through the superclass directly, as addPage(int, IFormPage) already does, so each form page is registered once. Fixes eclipse-platform#4107
A detached window is created as a child shell of the workbench window shell. The window manager keeps a child window with its owner, so clicking in a detached view that was moved over another application (e.g. on a second monitor) also brings the whole workbench window to the front, over that application. WBWRenderer already creates a top level shell for a window tagged with IPresentationEngine.WINDOW_TOP_LEVEL. Add the DETACHED_WINDOWS_TOP_LEVEL preference (node org.eclipse.e4.ui.workbench.renderers.swt, default false) that does the same for all detached windows, and a check box for it in General > Appearance. A top level shell has its own task bar entry, so a detached window made top level by the preference: - can be minimized (SWT.MIN, unless a style override is set), - has the label of the part it shows as title when the window has no label of its own, instead of an empty title. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Feo5dzUJyYJAvWuN78uu2X
Collect all matches first, then replace from last to first so patterns like "^ " with an empty replacement remove only one leading space per line instead of all leading spaces. Fixes eclipse-platform#2820 Signed-off-by: Edward Lo <ed700a@gmail.com>
FindReplaceDocumentAdapter returns no match when group().isEmpty(), so bare "^" never finds. Keep the ^[space] regression for issue 2820.
FindReplaceDocumentAdapter#replace() does not take an offset: it uses the matcher's current match and expands $n from it. Collecting all matches before replacing leaves that matcher exhausted, so each match has to be re-established before it is replaced - without the re-selection every replacement fails. The additional comparison of the re-selected offset against the stored one was defensive only. It never triggered: matches are replaced last to first, so the text of every pending match is unchanged and a forward search from its offset necessarily returns the same offset. Being unreachable, it also cannot be covered by a test. Drop it and document why the re-selection itself is required instead. Also let selectAll() reuse findAllMatches() rather than duplicating the same match walk, as raised in review. Add regression tests for re-matching during replace all: the anchor cases fail on the previous implementation, while the group-expansion case pins the re-selection requirement (it fails if the re-selection is removed).
replaceSelection() does not take an offset: it reads the adapter's current match and expands $n from it. Document this on the findAndSelect(match.x) call so the necessity of the re-selection is clear, following up on the review discussion where the surrounding guard was removed. Signed-off-by: Edward Lo <ed700a@gmail.com>
…lipse-platform#3639 - Remove dependency on PerformanceTestCaseJunit4. - Migrate OpenCloseWindowTest to use PerformanceMeter directly. - Migrate OpenClosePerspectiveTest to use PerformanceTestCaseJunit5. - Use CloseTestWindowsExtension instead of CloseTestWindowsRule. - Use @ParameterizedTest instead of @RunWith(Parameterized.class) Part of the work for eclipse-platform#3639
swt-lines-visible was never undone, so a Tree or Table kept its grid lines after the theme was switched or re-applied without that rule. The handler now remembers the value the widget had before CSS first styled it, and the Tree and Table element resets restore it, which keeps lines that the application turned on itself. Assisted-by: multiple AI agents and layers of automated tooling 🤖
…ipse-platform/eclipse.platform#2986 WizardDialog builds its shell with SWT.RESIZE but inherits isResizable() == false from Dialog, so hookZoomChangeListenerForDefaultSizedDialogs() installs adaptDefaultSizeListener on every wizard. That listener calls shell.setSize(shell.computeSize(...)), which sends the next SWT.Resize, and it has no re-entrancy guard: whenever the computed size is not a fixed point the listener recurses until the stack is exhausted. Let WizardDialog report the SWT.RESIZE bit of its shell style, and make the listener skip a nested call and a size that has not changed. Fixes eclipse-platform/eclipse.platform#2986 Signed-off-by: Philipp SALZGEBER <Philipp.SALZGEBER@bachmann.info>
Replacing a selected occurrence of the find string could change a different part of the document or silently do nothing. This happened whenever the selection no longer corresponded to the target's most recent search, e.g., after an undo restored a replaced match or after the user manually selected another occurrence of the find string. Replace now always acts on the selected match: if the selection is an occurrence of the find string, exactly that occurrence is replaced; otherwise, the next match is searched and selected as before. The target replaces the match of its most recent search, which is independent of the selection and outdated by any document change. FindReplaceLogic therefore searches forward from the start of the selection before replacing and only keeps the selection if that search yields exactly the selected text, which makes the selection the single source of truth for what gets replaced. Assisted-by: Claude Opus 5.5 <noreply@anthropic.com>
Resolved by recipe: 1 file(s); provenance index and policy recomputed.
Resolved by recipe: 0 file(s); provenance index and policy recomputed.
Resolved by recipe: 1 file(s); provenance index and policy recomputed.
Resolved by recipe: 0 file(s); provenance index and policy recomputed.
Resolved by recipe: 0 file(s); provenance index and policy recomputed.
Resolved by recipe: 0 file(s); provenance index and policy recomputed.
Resolved by recipe: 0 file(s); provenance index and policy recomputed.
Resolved by recipe: 0 file(s); provenance index and policy recomputed.
Resolved by recipe: 0 file(s); provenance index and policy recomputed.
Resolved by recipe: 0 file(s); provenance index and policy recomputed.
Resolved by recipe: 0 file(s); provenance index and policy recomputed.
Resolved by recipe: 0 file(s); provenance index and policy recomputed.
Resolved by recipe: 2 file(s); provenance index and policy recomputed.
Resolved by recipe: 0 file(s); provenance index and policy recomputed.
Resolved by recipe: 1 file(s); provenance index and policy recomputed.
Resolved by recipe: 0 file(s); provenance index and policy recomputed.
Resolved by recipe: 2 file(s); provenance index and policy recomputed.
Resolved by recipe: 0 file(s); provenance index and policy recomputed.
Resolved by recipe: 1 file(s); provenance index and policy recomputed.
Resolved by recipe: 0 file(s); provenance index and policy recomputed.
Resolved by recipe: 0 file(s); provenance index and policy recomputed.
Resolved by recipe: 0 file(s); provenance index and policy recomputed.
Resolved by recipe: 1 file(s); provenance index and policy recomputed.
Resolved by recipe: 1 file(s); provenance index and policy recomputed.
Resolved by recipe: 0 file(s); provenance index and policy recomputed.
Resolved by recipe: 1 file(s); provenance index and policy recomputed.
Resolved by recipe: 1 file(s); provenance index and policy recomputed.
Resolved by recipe: 1 file(s); provenance index and policy recomputed.
Resolved by recipe: 1 file(s); provenance index and policy recomputed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings 43 open upstream eclipse.platform.ui PRs into the fork. Each one is ready for review upstream (not a draft) and green on upstream CI.
Highlights:
JFace reusable breadcrumb viewers.
Quick selection in FilteredTree.
Stable sorting in FilteredList.
Freeze fixes: reentrant part activation, focus changes during activation, and the workspace lock when opening a search match.
Find/Replace improvements, CSS theming fixes, code-mining placeholders, and an image viewer editor.
Allowing smaller images to show in the workbench window eclipse-platform/eclipse.platform.ui#3169 Allowing smaller images to show in the workbench window
Optional filter text autocomplete support in chevron pop up eclipse-platform/eclipse.platform.ui#3336 Optional filter text autocomplete support in chevron pop up
Fix for multi threading issues in AnnotationMap eclipse-platform/eclipse.platform.ui#3397 Fix for multi threading issues in AnnotationMap
Tests for FormEditor #3764 eclipse-platform/eclipse.platform.ui#3765 Tests for FormEditor FormEditor fails to activate editor page eclipse-platform/eclipse.platform.ui#3764
Add auto-incrementing counter placeholder to Find/Replace #3842 eclipse-platform/eclipse.platform.ui#3843 Add auto-incrementing counter placeholder to Find/Replace Add auto-incrementing counter placeholder to Find/Replace eclipse-platform/eclipse.platform.ui#3842
Use OSGI tracing and debug options handling in org.eclipse.ui.workbench eclipse-platform/eclipse.platform.ui#4037 Use OSGI tracing and debug options handling in org.eclipse.ui.workbench
Display the count of results in Find/Replace overlay eclipse-platform/eclipse.platform.ui#4050 Display the count of results in Find/Replace overlay
Fix selection not updating when checking a tree item on Import window eclipse-platform/eclipse.platform.ui#4084 Fix selection not updating when checking a tree item on Import window
Show proper symlink decorations for broken symlinks eclipse-platform/eclipse.platform.ui#4158 Show proper symlink decorations for broken symlinks
Smart Import: offer to open/show already-imported projects eclipse-platform/eclipse.platform.ui#4170 Smart Import: offer to open/show already-imported projects
Add an expand/collapse hover button in search results tree view eclipse-platform/eclipse.platform.ui#4318 Add an expand/collapse hover button in search results tree view
Fix regex Replace All rematching line-start anchors eclipse-platform/eclipse.platform.ui#4373 Fix regex Replace All rematching line-start anchors
Count distinct files across the complete CompositeChange tree eclipse-platform/eclipse.platform.ui#4382 Count distinct files across the complete CompositeChange tree
Show Open/Close Project for mixed selections in Project Explorer eclipse-platform/eclipse.platform.ui#4398 Show Open/Close Project for mixed selections in Project Explorer
Fix duplicate page registration in FormEditor.addPage(IFormPage) eclipse-platform/eclipse.platform.ui#4406 Fix duplicate page registration in FormEditor.addPage(IFormPage)
Add highlight feature for resources in eclipse explorers eclipse-platform/eclipse.platform.ui#4414 Add highlight feature for resources in eclipse explorers
WizardDialog resizes itself in an endless loop after a DPI change ecl… eclipse-platform/eclipse.platform.ui#4428 WizardDialog resizes itself in an endless loop after a DPI change ecl…
Add preference to render detached windows as top level shells eclipse-platform/eclipse.platform.ui#4437 Add preference to render detached windows as top level shells
Show pinned editors first in the editor chevron list and in Ctrl+E when enabled eclipse-platform/eclipse.platform.ui#4450 Show pinned editors first in the editor chevron list and in Ctrl+E when enabled
Update "Project Explorer" tree view when projects are added/removed eclipse-platform/eclipse.platform.ui#4461 Update "Project Explorer" tree view when projects are added/removed
Add quick selection mode to the e4 FilteredTree eclipse-platform/eclipse.platform.ui#4493 Add quick selection mode to the e4 FilteredTree
Migrates two more performance tests from
PerformanceTestCaseJunit4to JUnit 5 as part of #3639 eclipse-platform/eclipse.platform.ui#4494 Migrates two more performance tests fromPerformanceTestCaseJunit4to JUnit 5 as part of Migrate away from PerformanceTestCaseJunit4 eclipse-platform/eclipse.platform.ui#3639Provide reusable breadcrumb viewer implementations in JFace #4495 eclipse-platform/eclipse.platform.ui#4496 Provide reusable breadcrumb viewer implementations in JFace Move generic breadcrumb implementation from JDT to JFace eclipse-platform/eclipse.platform.ui#4495
Set the SVG currentColor from the CSS theme at startup eclipse-platform/eclipse.platform.ui#4497 Set the SVG currentColor from the CSS theme at startup
Re-apply CSS colors that only match the inherited color eclipse-platform/eclipse.platform.ui#4499 Re-apply CSS colors that only match the inherited color
CodeMinings: Add support for rendering placeholder while resolving #3723 eclipse-platform/eclipse.platform.ui#4508 CodeMinings: Add support for rendering placeholder while resolving Prevent editor "jumping" by using placeholders for Code Minings eclipse-platform/eclipse.platform.ui#3723
Restore lines visibility of trees and tables on theme reset eclipse-platform/eclipse.platform.ui#4513 Restore lines visibility of trees and tables on theme reset
Sort by the undecorated label of styled decorating label providers eclipse-platform/eclipse.platform.ui#4517 Sort by the undecorated label of styled decorating label providers
Show theme controls dynamically on the Appearance preference page eclipse-platform/eclipse.platform.ui#4520 Show theme controls dynamically on the Appearance preference page
Make sorting in FilteredList and TwoPaneElementSelector stable eclipse-platform/eclipse.platform.ui#4523 Make sorting in FilteredList and TwoPaneElementSelector stable
Find/Replace: replace the selected match instead of the last found one eclipse-platform/eclipse.platform.ui#4526 Find/Replace: replace the selected match instead of the last found one
Prevent reentrant part activation cycles causing UI freezes eclipse-platform/eclipse.platform.ui#4529 Prevent reentrant part activation cycles causing UI freezes
Rebuild the Section title bar image when its colors change eclipse-platform/eclipse.platform.ui#4532 Rebuild the Section title bar image when its colors change
Ignore focus changes while a part is being activated eclipse-platform/eclipse.platform.ui#4543 Ignore focus changes while a part is being activated
Recompute indent folding regions when folding is re-enabled eclipse-platform/eclipse.platform.ui#4545 Recompute indent folding regions when folding is re-enabled
Return visible views from getViewReferences() when no perspective is open eclipse-platform/eclipse.platform.ui#4548 Return visible views from getViewReferences() when no perspective is open
Draw a light border around the split editor area in the macOS theme eclipse-platform/eclipse.platform.ui#4554 Draw a light border around the split editor area in the macOS theme
Place the editor onboarding area in the folder's client area eclipse-platform/eclipse.platform.ui#4556 Place the editor onboarding area in the folder's client area
Set the dark theme preference before resetting widget colors eclipse-platform/eclipse.platform.ui#4557 Set the dark theme preference before resetting widget colors
Add an image viewer editor with zoom to the internal browser bundle eclipse-platform/eclipse.platform.ui#4558 Add an image viewer editor with zoom to the internal browser bundle
Keep valid code minings visible when a provider supplies an invalid position eclipse-platform/eclipse.platform.ui#4559 Keep valid code minings visible when a provider supplies an invalid position
Do not block the UI thread on the workspace lock when opening a match eclipse-platform/eclipse.platform.ui#4563 Do not block the UI thread on the workspace lock when opening a match
Keep the horizontal scroll position when the text viewer redraws again eclipse-platform/eclipse.platform.ui#4564 Keep the horizontal scroll position when the text viewer redraws again
Where an upstream PR met fork work, each conflict was resolved by reading both sides:
findExistingProject: both sides added it. The fork had it private with an //FLLDCIM anchor; upstream's revision is protected. Result: protected, with the anchor kept.org.eclipse.searchMANIFEST.MF: both bumped Bundle-Version; the higher version, 3.20.0, is kept.AllViewersTests: the fork's M3 viewer tests and upstream'sViewerComparatorDecoratedLabelTestare both in the suite.StackRenderer: upstream's client-area bounds, so the onboarding area no longer covers the tabs. The image decision still goes throughshouldShowOnboardingImage(bounds.height, imgHeight)(the small-image rule from Allowing smaller images to show in the workbench window eclipse-platform/eclipse.platform.ui#3169)._) were renamed to the fork's Java 21 form (unused). This affected 4 upstream test files.Verification on 97ad421:
_->unusedrenames, each confirmed to be exactly that recipe.