Skip to content

fix(layers): keep text position stable on first selection - #905

Merged
hm21 merged 4 commits into
hm21:stablefrom
saif-ellafi:fix/text-layer-selection-jump
Oct 24, 2026
Merged

hm21 merged 4 commits into
hm21:stablefrom
saif-ellafi:fix/text-layer-selection-jump

Conversation

@saif-ellafi

Copy link
Copy Markdown
Contributor

Description

Selecting a text layer could make it jump diagonally for one frame the first time it was selected. The layer’s selection padding and its position adjustment could briefly use different selection states. This change keeps them in sync, so selection no longer shifts the text.

Adds regression tests for boxed and unboxed text, different anchors, mouse and touch input, transformed layers, and multi-selection with text, emoji, and widget layers.

Related Issue: Closes #

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature which would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@hm21
hm21 merged commit b60f699 into hm21:stable Oct 24, 2026
3 checks passed
@hm21

hm21 commented Oct 24, 2026

Copy link
Copy Markdown
Owner

Thanks @saif-ellafi! With #906 merged, the _lastHitState rebuild that caused this jump is gone, so the change in layer_widget.dart was no longer needed (your test already passes with #906 alone and fails on the old code). I merged stable into the branch so the PR now adds just your regression tests, and reworded two comments that still referred to the removed hit notifier and the companion app. Merged and released in 14.20.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants