Bump for ghc-10 - #12374
Open
philderbeast wants to merge 7 commits into
Open
Bump for ghc-10#12374philderbeast wants to merge 7 commits into
philderbeast wants to merge 7 commits into
Conversation
philderbeast
force-pushed
the
bump/ghc-10
branch
from
September 22, 2026 18:09
b7d898d to
663f68c
Compare
philderbeast
force-pushed
the
bump/ghc-10
branch
from
September 22, 2026 18:13
663f68c to
935bbef
Compare
Mikolaj
reviewed
Sep 24, 2026
| } | ||
| } | ||
|
|
||
| -- | allow-newer: filepath:base only while we're using a pre-release of ghc-10 |
Member
There was a problem hiding this comment.
why this one can't be done in a project file, like the rest
Collaborator
Author
There was a problem hiding this comment.
That is better. I did this and left a conditional that will trigger a test failure with GHC >= 10.0.1.
Mikolaj
reviewed
Sep 24, 2026
| guessPackageName =<< case packageDir flags of | ||
| Flag a -> return a | ||
| NoFlag -> last . splitDirectories <$> getCurrentDirectory | ||
| NoFlag -> fromMaybe "" . safeLast . splitDirectories <$> getCurrentDirectory |
Member
There was a problem hiding this comment.
Is this empty string principled and always correct, or should this be error ..., or rather the cabal equivalent.
Collaborator
Author
There was a problem hiding this comment.
I was able to reduce this to just getCurrentDirectory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow building (and passing validate) with pre-releases of ghc-10. Adds allow-newer exceptions for ghc-10 and removes those that were added for ghc-9.14. Uses my forks of hashable and vector-th-unbox.
I tested this locally with the pre-release available through ghcup.