[four-random-common-words]

Issue: hashtopolis/server#886
Backend: hashtopolis/server#2499, hashtopolis/server#2500

Replaces the cracker version form with one that offers three ways to provide the binary:

• uploading an archive (with progress)
• letting the server download it from a URL
• importing an archive already present on the server

Cracker versions now belong to an access group, so the form asks for one, and New Task and Apply Hashlist only offer versions the user can access. On New Task the cracker selection moves directly under the hashlist. GlobalService gains a generic blob download, and the backend pin and generated API types are updated to the cracker access group stack.

[novasam23]

Only two minor issues: If I add a new binary version via the upload method and then happen to navigate away from the "New Cracker Version" page mid-upload, the frontend still tries to create a new binary version via a POST.

This is because the takeUntilDestroyed doesn't just unsubscribe when the page is destroyed, it completes, which then triggers resolve and eventually submitCreate() with an incomplete upload.

web-ui/src/app/config/engine/crackers/cracker-version-form/cracker-version-form.component.ts

Line 285 in 93a2e2a

.pipe(takeUntilDestroyed(this.destroyRef))

That then results in a notification because the incomplete upload of the binary is not in the import directory (it probably is still in the temp folder of the tus upload at this point):

Failed to create cracker version: Failed to store the archive: Source file in import directory does not exist! The uploaded archive remains in the server import directory.

This also ties into the second issue, which is that UploadTUSService.uploadFile returns an Observable with no teardown, it never calls upload.abort(). So what also happen if a user navigates away mid-upload is, that the upload still continues in the background.

The test below somehow did not catch this:

web-ui/src/app/config/engine/crackers/cracker-version-form/cracker-version-form.component.spec.ts

Line 191 in 93a2e2a

it('does not create the version when the page is left during the upload', () => {

The effects of these bugs are pretty minor because a cracker binary is only a few MBs and probably uploaded within an instant in most cases.

[four-random-common-words]

The test below somehow did not catch this:

Thanks for the feedback 👍 The test was flawed because it did not await component.onSubmit
I will fix the test and the component. For the service, I think I would like to takle these problems in a separate PR, as other forms depend on it as well.