Skip to content

fix: preserve comma arrays with query-string 4 - #1438

Open
sean0407 wants to merge 1 commit into
googlemaps:masterfrom
sean0407:codex/google-maps-services-js-1430-query-string-range
Open

sean0407 wants to merge 1 commit into
googlemaps:masterfrom
sean0407:codex/google-maps-services-js-1430-query-string-range

Conversation

@sean0407

Copy link
Copy Markdown

Fixes #1430

query-string@4.3.4 ignores arrayFormat: "comma" and serializes an array as repeated query parameters. The serializer now joins arrays when comma format is requested, so the fields remain in one parameter. The regression test covers fields: ["geometry", "name"].

Changed files:

  • src/serialize.ts
  • src/serialize.test.ts

Checks:

  • npm run build — passed.
  • jest --runInBand --runTestsByPath src/serialize.test.ts with the lockfile dependency query-string@7.1.3 — 12/12 passed.
  • The comma-array regression test with query-string@4.3.4 — passed.
  • ESLint on both changed files — passed.
  • npm run lint — reports 11 Prettier errors in unchanged files under e2e/geocode and src/common.ts / src/geocode.

@google-cla

google-cla Bot commented Oct 21, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incompatible query-string dependency version range

1 participant