Skip to content

Fix nanmedian validation #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sahilphad07-sudo wants to merge 2 commits into from
Closed

Fix nanmedian validation #519

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a077f5e
Fix nanmedian infinite dimension validation
sahilphad07-sudo Oct 9, 2026
474d4a2
Fix nanmedian infinite dimension validation
sahilphad07-sudo Oct 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions inst/Descriptive_Statistics/nanmedian.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,11 +72,11 @@
m = __colmedian__ (x(:).');
return;
elseif (isscalar (dim))
if (! isnumeric (dim) || fix (dim) != dim || dim <= 0)
if (! isnumeric (dim) || ! isfinite (dim) || fix (dim) != dim || dim <= 0)
error ("nanmedian: DIM must be a positive integer.");
endif
elseif (isnumeric (dim) && isvector (dim))
if (any (fix (dim) != dim) || any (dim <= 0))
if (any (! isfinite (dim)) || (fix (dim) != dim) || any (dim <= 0))
error ("nanmedian: VECDIM must be a vector of positive integers.");
endif
dim = sort (dim);
Expand Down Expand Up @@ -180,5 +180,8 @@
%!error <nanmedian: X must be numeric.> nanmedian ({3})
%!error <nanmedian: DIM must be a positive integer.> nanmedian (ones (3), 0)
%!error <nanmedian: DIM must be a positive integer.> nanmedian (ones (3), 1.5)
%!error <nanmedian: DIM must be a positive integer.> nanmedian (ones (3), Inf)
%!error <nanmedian: VECDIM must be a vector of positive integers.> ...
%! nanmedian (ones (3), [1 Inf])
%!error <nanmedian: VECDIM must contain non-repeating positive integers.> ...
%! nanmedian (ones (3, 3, 3), [2, 2, 3])
Loading