Repository navigation
fix(ui): move add folder to application menu - #319
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #318
This moves the Add Folder shortcut into the main window hamburger menu, between Add Account and Preferences. The action follows the selected account and is disabled when no account is available. The button above the folder list is gone.
The shared Add Folder dialog now shows
Account: user (server)before the folder fields. The same account line remains visible when validation reopens the dialog. Existing translations cover the new UI, and Preferences remains unchanged.Tests cover the menu action, its disabled state without accounts, active account selection with A/B fixtures, removal of the old button, and the destination account label.
Local checks:
cargo buildcargo test: 769 passed, 0 failed, 3 ignoredcargo clippy --all-targets -- -D warningscargo fmt --all -- --checkgit diff --check