Revert "Add selective release-asset syncing (--os-include, --os-exclu… - #194
Closed
JohnBreault wants to merge 4 commits into
Closed
JohnBreault wants to merge 4 commits into
JohnBreault wants to merge 4 commits into
Conversation
…ive release-asset syncing Allows GHES admins to select which CodeQL bundle OS assets to sync and which compression format (gz or zst) to use, reducing load on the GHES VM and avoiding syncing unnecessary release assets. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…et-sync Add selective release-asset syncing (--os-include, --os-exclude, --compression-format)
…de, --compression-format)"
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The filtering feature and its references are consistently removed across implementation, commands, documentation, and tests.
Review effort: Balanced
Findings: None
What changed in this PR
Reverts selective CodeQL release-asset syncing and restores synchronization of all release assets.
Changes:
- Removes OS/compression filtering flags and documentation.
- Restores unconditional asset downloading and simplifies the pull API.
- Removes filter-specific tests and ignore configuration.
| File | Description |
|---|---|
README.md |
Removes documentation for reverted flags. |
internal/pull/pull.go |
Removes asset filtering logic. |
internal/pull/pull_test.go |
Removes filter-specific tests. |
cmd/sync.go |
Removes filter validation and arguments. |
cmd/pull.go |
Removes filtering flags and parsing. |
.gitignore |
Reverts the releases-directory exclusion. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Author
|
reverted by SIRT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…de, --compression-format)"