Handle DOM/JSON edge cases - #67
Merged
Merged
Conversation
takezoe
approved these changes
Sep 19, 2026
| const logo = document.querySelector('header.main-header a.logo'); | ||
| if (!logo) { | ||
| return; | ||
| } |
Member
There was a problem hiding this comment.
I will merge this PR because it won't degrade anything.
However, I think this guard doesn't work as expected in the first place because <Root /> is already added at this point. It should be checked index.js before adding it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds null-checks and try/catch around DOM lookups and JSON.parse in the explorer sidebar. Split out of #64 per review request.