Repository navigation
test(tracing): Remove DBAL v2-only errorCode test from DBAL v4 connection test to drop baseline entry - #1122
Merged
Conversation
…tion test to drop baseline entry
…AL v4 The DBAL v4 connection test was copied from the v2/v3 test and kept the v2/v3 version guards, so all four errorCode/errorInfo tests were always skipped under the class-level DBAL v4 requirement. - Remove testErrorInfo, which mocks errorInfo() that DBAL 4's driver Connection does not have, and drop its PHPStan baseline entry. - Remove the DBAL v3 guards from the BadMethodCallException tests so they cover the path DBAL 4 actually takes, and assert on the V4 class name that __METHOD__ produces.
stayallive
approved these changes
Nov 16, 2026
Collaborator
|
There were also some other copy-pasts codes left from other DBAL versions. Added some more cleanup. |
stayallive
marked this pull request as ready for review
November 16, 2026 09:56
stayallive
enabled auto-merge (squash)
November 16, 2026 09:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes this entry from
phpstan-baseline.neon:TracingDriverConnectionForV4Testskips the whole class unless DBAL 4 is installed, buttestErrorCode()skips itself unless DBAL 2 is installed. Because of that, it never runs. It is also the only place that mockserrorCode(), which DBAL 4'sConnectiondoes not have. This PR deletes that unreachable test. Only test code changes, and shipped code stays the same.via automation
sched_a59acc45df166a80a839d0b32321e740· Run IDsched_a59acc45df166a80a839d0b32321e740:1794819600000.--
View Session [Sentry]