Skip to content

test(tracing): Remove unused databasePlatform property in DBAL v4 factory test to drop baseline entry - #1121

Draft
sentry-junior[bot] wants to merge 1 commit into
masterfrom
junior/phpstan-dbal-v4-factory-test-unused-platform
Draft

sentry-junior[bot] wants to merge 1 commit into
masterfrom
junior/phpstan-dbal-v4-factory-test-unused-platform

Conversation

@sentry-junior

@sentry-junior sentry-junior Bot commented Nov 15, 2026

Copy link
Copy Markdown
Contributor

Removes this entry from phpstan-baseline.neon:

Property Sentry\SentryBundle\Tests\Tracing\Doctrine\DBAL\TracingDriverConnectionFactoryV4Test::$databasePlatform is never read, only written. (tests/Tracing/Doctrine/DBAL/TracingDriverConnectionFactoryV4Test.php)

setUp() created an AbstractPlatform mock and stored it on $databasePlatform, but no test read it: each test builds its own local platform mock. This drops the property and the assignment.

Test-only change; the tests themselves are unchanged.

via automation sched_a59acc45df166a80a839d0b32321e740 · Run ID sched_a59acc45df166a80a839d0b32321e740:1794733200000.

--

View Session [Sentry]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants