Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
011) porque a regex anterior extraiu um trecho em vez de validar o valor completo.Description
src/validator-docs/Rules/Ddd.phppara exigir exatamente dois dígitos com'/^[1-9]{2}$/'e converte o valor parastringantes de validar.in_array($dddExtracted, $dddExisting, true)para comparação estrita.tests/TestValidator.phppara garantir falha em entradas de três dígitos ('011') e em entradas alfanuméricas ('11a').Testing
php -l src/validator-docs/Rules/Ddd.phpephp -l tests/TestValidator.phpe ambos retornaram sem erros (success).php -rpara a regraDddverificou comportamento esperado (011=false,11=true) (success).composer teste./vendor/bin/phpunit -c phpunit.xml.distnão foram executáveis no ambiente atual por falta de binários emvendor/e por incompatibilidade entre ocomposer.locke a versão do PHP (fail).composer installfalhou devido a incompatibilidades de versão PHP declaradas nas dependências docomposer.lock(fail).Codex Task