Repository navigation
feat(vm): add expectCall with CallKind - #947
Open
agnij-dutta wants to merge 1 commit into
Open
agnij-dutta wants to merge 1 commit into
agnij-dutta wants to merge 1 commit into
Conversation
agnij-dutta
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse and
onbjerg
as code owners
November 12, 2026 06:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
expectCall(CallKind kind, address callee, bytes calldata data)and theCallKindenum (Call,DelegateCall,StaticCall) from foundry-rs/foundry#17503 toVm.sol, and updates theVminterface ID intest/Vm.t.sol(0x9ae1b86fto0xc6fb98f9, the old ID XOR the new selector0x5c1a2096).VmSafeis unchanged.Generated with
scripts/vm.py --fromthecheatcodes.jsonon the foundry branch. I only took the lines for this cheatcode, so the doc-comment updates that are already on foundry master but not here yet (and the transient storage cheatcodes in #946) stay out of this diff.forge test --match-path test/Vm.t.solpasses andforge fmt --checkis clean on both files.This should merge after foundry-rs/foundry#17503.