Repository navigation
Conversation
basantzp
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse and
onbjerg
as code owners
November 5, 2026 00:16
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #940
Summary
Adds the Ethereum protocol
SYSTEM_ADDRESS(0xffffFFFfFFffffffffffffffFfFFFfffFFFfFFfE,type(uint160).max - 1) constant to bothStdConstantsandCommonBase, along with unit tests inStdConstantsTestandCommonBaseTest.Motivation & Context
SYSTEM_ADDRESS(0xfffffffffffffffffffffffffffffffffffffffe). Tests inspecting logs viavm.getRecordedLogs()require filtering out system ETH transfer events by emitter address.SYSTEM_ADDRESSis the caller of core system contracts (EIP-4788 beacon roots, EIP-2935 historical block hashes, EIP-7002 execution layer exits, and EIP-7251 consolidation requests). Testing contracts that enforcerequire(msg.sender == SYSTEM_ADDRESS)requiresvm.prank(SYSTEM_ADDRESS).SYSTEM_ADDRESSinStdConstantsandCommonBaseprevents projects from repeatedly defining custom magic constants and avoids EIP-55 checksum errors.Changes
src/StdConstants.sol: AddedSYSTEM_ADDRESS = 0xffffFFFfFFffffffffffffffFfFFFfffFFFfFFfE;src/Base.sol: AddedSYSTEM_ADDRESSconstant toCommonBasetest/StdConstants.t.sol: AddedtestSystemAddressverifying checksum literal and derivation fromtype(uint160).max - 1test/CommonBase.t.sol: AddedtestSystemAddressValueasserting value parity withStdConstants.SYSTEM_ADDRESS