Skip to content

Show a dead check job as ended and let its set recover from the set view - #2658

Merged
pournasserian merged 4 commits into
v2from
2628-dead-check-jobs
Oct 20, 2026
Merged

pournasserian merged 4 commits into
v2from
2628-dead-check-jobs

Conversation

@pournasserian

Copy link
Copy Markdown
Member

Closes #2628

What

Follow-ups from the independent review of #2607 (F-DSK, #2422).

  • The checks card reads the job's state:
    • A job that is queued or running shows its progress.
    • A set in checks running whose job ended without a run says the check run ended without a result. The person who opened it gets "Run the checks again", which calls IChangeSetChecks.SubmitAsync. Its recovery fails the set, so the set can be reopened.
    • An open set says the checks run when it is submitted.
    • A set past open with no stored run says that no check results are stored for it.
  • Submit, and running the checks again, are offered only on sets a person opened. Agents submit their own sets by tool, so pressing S on an agent's open set no longer splits its work in two. The handler applies the same rule, whatever a post claims.
  • Finding messages, pointers and excerpts sit in <bdi>, so a right-to-left override in a judgement's text can't reorder the other parts.

Tests

  • Host, on SQLite and PostgreSQL:
    • A set whose check job died shows the ended note and "Run the checks again", and running them again moves the set to checks failed.
    • A failing run from an active terms check shows its finding, its severity and the isolated parts.
  • bUnit:
    • A person's open set offers Submit, and an agent's offers none.
    • A job that ended as dead, failed or succeeded reads as ended, and its opener can run the checks again.
    • A passed run with no results shows that it passed.
    • A set past open with no run says so.
    • Both severities show their label: blocks and warns.
    • A finding's parts are each in <bdi>.
  • Browser: the axe check renders a set with a failing run, in both directions and themes.

dotnet build -warnaserror, the unit and bUnit suite, and the set view, review, keyboard and accessibility tests pass locally, on SQLite and on PostgreSQL. No new package and no new project reference.

Checklist

  • Linked to an issue a maintainer has confirmed
  • Targets v2
  • Tests or docs updated where behaviour changed
  • No tool-generated co-author trailers or footers

@pournasserian
pournasserian merged commit 47c77b1 into v2 Oct 20, 2026
2 checks passed
@pournasserian
pournasserian deleted the 2628-dead-check-jobs branch October 20, 2026 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:desk Review desk (DSK) type:bug Defect v2 FluentCMS v2 (v2 branch)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show a dead check job as ended and let its set recover from the desk

1 participant