chore(kits): add a LICENSE to each kit - #3217
Merged
Merged
Conversation
npm packs only the kit's own directory, so the root LICENSE never reached installs. Each kit now ships a copy of the Apache 2.0 license text.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds the Apache License Version 2.0 to multiple kit directories, including bigquery-firestore-export, delete-user-data, firestore-bigquery-export, firestore-bundle-builder, firestore-counter, firestore-genai-chatbot, firestore-incremental-capture, firestore-send-email, firestore-translate-text, firestore-vector-search, rtdb-limit-child-nodes, speech-to-text, and storage-resize-images. I have no feedback to provide.
CorieW
force-pushed
the
chore/kits-add-license
branch
from
September 28, 2026 12:52
ef01b7b to
780ac0b
Compare
cabljac
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each kit is published to npm as its own package, and npm packs only the kit's directory. The root
LICENSEnever reached installs, so users got the"license": "Apache-2.0"field and the source headers but not the license text, which Apache 2.0 section 4(a) asks redistributors to include.This copies the root
LICENSEinto all 13 kit directories. No kit sets afileslist, so npm picks the file up without further changes.This is a new pattern for the repo:
firestore-bigquery-change-tracker, also published to npm, has noLICENSEeither. Open question: keep 13 copies, or have the release step copy the root file in instead?Not verified: no
npm packwas run.