Conversation
|
⏩ The changelog entry check has been skipped since the "no changelog" label is present. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4474 +/- ##
==========================================
+ Coverage 72.42% 72.62% +0.20%
==========================================
Files 975 975
Lines 46617 46682 +65
Branches 10069 10081 +12
==========================================
+ Hits 33760 33897 +137
+ Misses 11857 11794 -63
+ Partials 1000 991 -9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Build-tools currently starts
record-sim, which captures and encodes the simulator screen separately from serve-sim's WebRTC stream. The serve-sim stack now records from its shared H.264 output, so build-tools should use that client and remove the extra binary.Depends on expo/serve-sim#208 being released first.
How
Start
serve-sim record-videousing the same serve-sim package spec as the preview. Wait for the token-bearing preview and recording start acknowledgement, then stop with SIGINT and wait for the manifest; retain SIGKILL fallback and retries. Removerecord-simsource and worker packaging. The upload step and manifest schema are unchanged.Test Plan
The built local serve-sim CLI was also exercised in a Tart VM (Xcode 26.4, pinned iPhone 17 UDID
EF9955A9-7D07-4D5F-BC33-1A946BB52958). Recording with 0, 1, and 2 H.264 WebRTC viewers produced the existing manifest schema and decodable MP4s. The two-viewer run showed 357 shared encode completions, 353 frames sent to each peer, and 361 MP4 frames over seven seconds. This validates the serve-sim CLI contract and upload manifest shape; a full hosted EAS worker run remains unverified.