Skip to content

binary-search-tree: avoid panic on test fail #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kotp merged 1 commit into from
Oct 30, 2025
Merged

binary-search-tree: avoid panic on test fail #528

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions exercises/practice/binary-search-tree/test_binary_search_tree.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ test "data is retained" {
try testing.expectEqual(null, o.left);
try testing.expectEqual(null, o.right);
} else {
unreachable;
try testing.expectEqual(false, true); // tree.root should not be null
}
}

Expand All @@ -41,11 +41,11 @@ test "insert data at proper node-smaller number at left node" {
try testing.expectEqual(null, l.left);
try testing.expectEqual(null, l.right);
} else {
unreachable;
try testing.expectEqual(false, true); // o.left should not be null
}
try testing.expectEqual(null, o.right);
} else {
unreachable;
try testing.expectEqual(false, true); // tree.root should not be null
}
}

Expand All @@ -61,11 +61,11 @@ test "insert data at proper node-same number at left node" {
try testing.expectEqual(null, l.left);
try testing.expectEqual(null, l.right);
} else {
unreachable;
try testing.expectEqual(false, true); // o.left should not be null
}
try testing.expectEqual(null, o.right);
} else {
unreachable;
try testing.expectEqual(false, true); // tree.root should not be null
}
}

Expand All @@ -82,10 +82,10 @@ test "insert data at proper node-greater number at right node" {
try testing.expectEqual(null, r.left);
try testing.expectEqual(null, r.right);
} else {
unreachable;
try testing.expectEqual(false, true); // o.right should not be null
}
} else {
unreachable;
try testing.expectEqual(false, true); // tree.root should not be null
}
}

Expand All @@ -108,17 +108,17 @@ test "can create complex tree" {
try testing.expectEqual(null, ll.left);
try testing.expectEqual(null, ll.right);
} else {
unreachable;
try testing.expectEqual(false, true); // l.left should not be null
}
if (l.right) |lr| {
try testing.expectEqual(3, lr.data);
try testing.expectEqual(null, lr.left);
try testing.expectEqual(null, lr.right);
} else {
unreachable;
try testing.expectEqual(false, true); // l.right should not be null
}
} else {
unreachable;
try testing.expectEqual(false, true); // o.left should not be null
}
if (o.right) |r| {
try testing.expectEqual(6, r.data);
Expand All @@ -127,20 +127,20 @@ test "can create complex tree" {
try testing.expectEqual(null, rl.left);
try testing.expectEqual(null, rl.right);
} else {
unreachable;
try testing.expectEqual(false, true); // r.left should not be null
}
if (r.right) |rr| {
try testing.expectEqual(7, rr.data);
try testing.expectEqual(null, rr.left);
try testing.expectEqual(null, rr.right);
} else {
unreachable;
try testing.expectEqual(false, true); // r.right should not be null
}
} else {
unreachable;
try testing.expectEqual(false, true); // o.right should not be null
}
} else {
unreachable;
try testing.expectEqual(false, true); // tree.root should not be null
}
}

Expand Down