Skip to content

Fix keymap help float to respect NormalFloat styling #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
esmuellert merged 2 commits into from
Sep 11, 2026
Merged

Fix keymap help float to respect NormalFloat styling #560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3350b3
Initial plan
Copilot Sep 10, 2026
22119dc
fix: use NormalFloat in keymap help window
Copilot Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lua/codediff/ui/keymap_help.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,7 @@ function M.toggle(tabpage)
title_pos = "center",
})
vim.wo[win].cursorline = false
vim.wo[win].winhighlight = "NormalFloat:Normal"
vim.wo[win].winhighlight = "NormalFloat:NormalFloat"

-- Track window in session for toggle
if session then
Expand Down
13 changes: 13 additions & 0 deletions tests/keymap/keymap_help_spec.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,19 @@ describe("keymap help popup", function()
cleanup()
end)

it("uses NormalFloat for the help window body highlight", function()
local tabpage, cleanup = open_standalone()

keymap_help.toggle(tabpage)
local session = lifecycle.get_session(tabpage)
local win = session and session._help_win
assert.is_true(win ~= nil and vim.api.nvim_win_is_valid(win), "help window should open")
assert.are.same("NormalFloat:NormalFloat", vim.wo[win].winhighlight)
keymap_help.toggle(tabpage)

cleanup()
end)

it("does not advertise a key disabled in config", function()
local tabpage, cleanup = open_standalone({ keymaps = { view = { quit = false, toggle_compact = false } } })

Expand Down
Loading