Repository navigation
Refactor MType into a string enum - #1251
Merged
Merged
Conversation
JulienVig
force-pushed
the
refactor-mtype
branch
2 times, most recently
from
October 9, 2026 14:57
3224f40 to
15d2ea9
Compare
JulienVig
added this pull request to stack #1252
October 9, 2026 15:46
JulienVig
force-pushed
the
refactor-mtype
branch
from
October 13, 2026 14:38
15d2ea9 to
ab3e70e
Compare
JulienVig
force-pushed
the
refactor-mtype
branch
from
October 13, 2026 14:41
ab3e70e to
f78745a
Compare
JulienVig
marked this pull request as ready for review
October 13, 2026 14:41
JulienVig
added a commit
that referenced
this pull request
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current
MTypeenum implicitly assigns an integer value to each message type. This means that inserting a new message, reorder messages, deleting messages, etc. change the implicit value of other messages. These values are what actually identify the message type. Differing message values between a client and a server or between peers can lead to unexpected errors and can be hard to troubleshoot.I refactored the
MTypeenum to use explicit string values such that changes the value of one message type doesn't impact the others.