Repository navigation
Conversation
CTabItem gets setBackground and setSelectionBackground, mirroring the foreground pair, so applications can color single tabs (for example per database connection) without subclassing the renderer and reaching into private fields. The renderer fills the tab and the hidden close button area with the item color. Items without own colors render as before. Assisted-by: multiple AI agents and layers of automated tooling 🤖
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CTabItem gets setBackground and setSelectionBackground, mirroring the existing setForeground and setSelectionForeground pair. Applications such as DBeaver color editor tabs per connection and today have to subclass the renderer and reach into private fields of CTabItem and the renderer, including emptying closeRect to hide the folder-colored patch behind the close button.
The default renderer now fills a tab with its item color, unselected or selected, and uses that color behind the hidden close button. Getters return the item's own color or null, so callers can tell an own color from the inherited one, and items without own colors render exactly as before. Snippet396 shows tabs with different colors, and the new tests cover the API contract plus a pixel check of the painted tabs.