Repository navigation
feat(xls): support optional zero-based byte numbering - #937
Open
timothyanderson096-ocdealcheck wants to merge 1 commit into
Open
timothyanderson096-ocdealcheck wants to merge 1 commit into
timothyanderson096-ocdealcheck wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #812.
Add
xlsExportByteBaseandxlsImportByteBase(integer 0 or 1) for XLS/XLSX. Both default to 1, preserving existing spreadsheets and conversions. For example:Only the displayed byte number changes; bit numbering and signal positions are preserved. Separate settings also allow one-based input to become zero-based output in a single conversion. The input base is explicit rather than inferred from the smallest signal byte, since a zero-based workbook may have no signal in byte 0. CSV output is unchanged.
Regression coverage checks both Excel formats, all three Motorola bit modes, unaligned signals, both value-table layouts, empty-frame rows, unchanged worksheet cells, CLI conversions with signals starting after byte 0, and invalid settings. Before implementation, the new API cases produced 36 failures and one passing CSV control; all eight new CLI cases failed because the flags were absent.
Validation on Linux, Python 3.13.16, based on development
06e852d:tox -e gh: 424 passed, 1 skipped.python -m twine check --strict dist/*: both passed.git diff --check: passed.The Windows/macOS and other Python-version jobs remain for upstream CI. Prepared and reviewed with AI assistance.
Timothy Anderson — Spotted Ridge Engineering / OC Labs
GDN — Global Decision Network
timothyanderson096@gmail.com · Engineering evidence