Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved issues were identified, and the change includes test coverage.
Review effort: Lite
Findings: None
What changed in this PR
Adds an early logging-sampling hook to reject records before enrichment, redaction, or formatting.
Changes:
- Adds category/level sampling support.
- Applies early sampling during logging and enablement checks.
- Adds tests and updates the public API baseline.
| File | Description |
|---|---|
test/Libraries/Microsoft.Extensions.Telemetry.Tests/Logging/ExtendedLoggerTests.cs |
Tests early rejection behavior. |
src/Libraries/Microsoft.Extensions.Telemetry/Logging/ExtendedLoggerFactory.cs |
Passes category names to loggers. |
src/Libraries/Microsoft.Extensions.Telemetry/Logging/ExtendedLogger.cs |
Performs early sampling. |
src/Libraries/Microsoft.Extensions.Telemetry.Abstractions/Sampling/LoggingSampler.cs |
Defines the sampling hook. |
src/Libraries/Microsoft.Extensions.Telemetry.Abstractions/Microsoft.Extensions.Telemetry.Abstractions.json |
Records the public API addition. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
amadeuszl
commented
Sep 23, 2026
| /// only the supplied values and ambient state. It may be called more than once for the same log record, | ||
| /// so implementations should return a stable decision. The default implementation enables the log record. | ||
| /// </remarks> | ||
| public virtual bool ShouldSample(string categoryName, LogLevel logLevel) => true; |
Contributor
Author
There was a problem hiding this comment.
instead of that we could bring new class eg. EarlyLoggingSampler
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables wiring up early sampling, so it skips log record creation early
Microsoft Reviewers: Open in CodeFlow