Skip to content

Deprecation -> Error for Package Not Accessible Without Static Import #23968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thewilsonator merged 1 commit into from
Oct 5, 2026
Merged

Deprecation -> Error for Package Not Accessible Without Static Import #23968

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions compiler/src/dmd/typesem.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1601,11 +1601,7 @@ private void resolveHelper(TypeQualified mt, Loc loc, Scope* sc, Dsymbol s, Dsym
// Same check as in dotIdSemanticProp(DotIdExp)
else if (sm.isPackage() && checkAccess(sc, sm.isPackage()))
{
// @@@DEPRECATED_2.106@@@
// Should be an error in 2.106. Just remove the deprecation call
// and uncomment the null assignment
eSink.deprecation(loc, "%s %s is not accessible here, perhaps add 'static import %s;'", sm.kind(), sm.toPrettyChars(), sm.toPrettyChars());
//sm = null;
sm = null;
}
}
if (global.errors != errorsave)
Expand Down
4 changes: 2 additions & 2 deletions compiler/test/fail_compilation/ice10598.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
// EXTRA_SOURCES: imports/ice10598a.d imports/ice10598b.d
/* TEST_OUTPUT:
---
fail_compilation/imports/ice10598a.d(5): Deprecation: module imports.ice10598b is not accessible here, perhaps add 'static import imports.ice10598b;'
fail_compilation/imports/ice10598a.d(5): Deprecation: module imports.ice10598b is not accessible here, perhaps add 'static import imports.ice10598b;'
fail_compilation/imports/ice10598a.d(5): Error: undefined identifier `ice10598b` in package `imports`, perhaps add `static import imports.ice10598b;`
fail_compilation/imports/ice10598a.d(5): Error: undefined identifier `ice10598b` in package `imports`, perhaps add `static import imports.ice10598b;`
---
*/

Expand Down
2 changes: 1 addition & 1 deletion compiler/test/fail_compilation/test21651.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// EXTRA_SOURCES: imports/test21651b.d
/* TEST_OUTPUT:
---
fail_compilation/test21651.d(11): Deprecation: module imports.test21651b is not accessible here, perhaps add 'static import imports.test21651b;'
fail_compilation/test21651.d(11): Error: undefined identifier `test21651b` in package `imports`, perhaps add `static import imports.test21651b;`
---
*/

Expand Down
Loading