You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR can merge after the existing Transaction Service producer and SIT topic/configuration PRs are available. There is no required delay between merges. Enable ledger.posting.consumer.enabled only after the governed topic and producer are deployed, then roll out Ledger Service with image digital-bank-java/ledger-service:0.0.4.
No public HTTP route is added. The consumer maps the governed command into the existing internal ledger posting path, while the inbox and database uniqueness constraints protect redelivery and concurrent processing.
Merge order: those Transaction Service and SIT configuration changes are already merged. This Ledger consumer PR can merge now; no delay is required. Enable ledger.posting.consumer.enabled only after the governed Kafka topic and producer are deployed, then roll out Ledger Service.
Verification on the branch: ./mvnw --batch-mode --no-transfer-progress verify passed with 21 unit-phase tests and 28 Testcontainers PostgreSQL integration tests; git diff --check passed. The consumer is disabled by default and adds no public HTTP route.
Release-safety correction: the consumer branch now publishes image digital-bank-java/ledger-service:0.0.4 and Helm chart 0.4.0 instead of reusing the existing 0.0.3/0.3.0 release. Helm lint, template rendering, and git diff --check pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LedgerPostingRequested.v1commands in Ledger Service.0.0.4with Helm chart0.4.0.Project tracking
Verification
./mvnw --batch-mode --no-transfer-progress verifyhelm lint helm --strict --values helm/values-sit.yamlhelm template ledger-service helm --namespace digital-bank-sit --values helm/values-sit.yamlgit diff --checkMerge and rollout
This PR can merge after the existing Transaction Service producer and SIT topic/configuration PRs are available. There is no required delay between merges. Enable
ledger.posting.consumer.enabledonly after the governed topic and producer are deployed, then roll out Ledger Service with imagedigital-bank-java/ledger-service:0.0.4.No public HTTP route is added. The consumer maps the governed command into the existing internal ledger posting path, while the inbox and database uniqueness constraints protect redelivery and concurrent processing.