Repository navigation
Call the first stage static analysis, not an AST - #16
Merged
Merged
Conversation
pySigma builds an intermediate representation of the rule and the pipeline walks it; nothing here is an abstract syntax tree. Rename so the product says what it does: - Card title "Parsed AST" -> "Parsed structure"; tooltip copy now says the IR is produced by static analysis of the rule - API response key `ast` -> `structure` (run_pipeline + tests + types) - Provenance `deterministic:ast` -> `deterministic:static`, displayed as "Deterministic · static analysis" (backend results, golden fixtures, frontend labels, How-this-works provenance sentence) - Frontend: AstCard -> StructureCard, lib/ast.ts -> lib/structure.ts (+ test), AstResult/AstNode/AstLine/flattenAst -> Structure* Also wires oxlint into CI: `npm run lint` script and a "Frontend lint" step after typecheck + vitest. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
SonarCloud analysis · PR #16Quality gate: ❌ Failed · Open in SonarCloud
Open issues on new code: 0No open issues on the changed code. 🎉 Commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
pySigma builds an intermediate representation (IR) of the rule and the pipeline walks it. Calling that an "AST" overstated what happens; "static analysis" and "parsed structure" are the honest terms. Renamed consistently, code included.
What changed
ast→structure(run_pipeline, its tests, frontend types/consumers).deterministic:ast→deterministic:staticin backend results, all seven golden fixtures, and frontend types; displayed as "Deterministic · static analysis". The single provenance sentence on How-this-works updated to match (nothing else on that page touched).AstCard.tsx→StructureCard.tsx,lib/ast.ts→lib/structure.ts(+ test),AstResult/AstNode/AstLine/flattenAst→Structure*.npm run lint(oxlint) as a "Frontend lint" step after typecheck + vitest.Golden fixture
parsesections are unchanged apart from provenance values (their keys are test-local, not API keys). README untouched.Verification
pytest: 201 passedtsc --noEmit -p tsconfig.app.json: cleanvitest run: 20 passed (6 files)vite build: OKoxlint: 0 errors (5 pre-existing warnings in files not otherwise part of this change; listed in the session report)🤖 Generated with Claude Code