Repository navigation
Say what a strict choice keeps of a native-script word - #1148
Merged
Merged
Conversation
A strict choice keeps a native-script word's readings, name readings included, exactly as a plain choice of the same languages keeps them: a reading written default = false stays off unless its file is chosen (strict pt reads गुरु प्रसाद शर्मा title गुरु). Seven sites said "native-script vocabulary", leaving the name readings unsaid (Lexicon.strict, parser_for and its refusal, the UNCHOOSABLE comment, AGENTS.md, mechanisms.md, decisions/vocabulary-model's Standing summary, the RFC), and #1146/#1147's customize.rst and docs/AGENTS.md said a word in another script keeps "every file's" readings. Also from the post-merge review of af7431c: the README's first-build cost of a choice includes the reading index only unless a parse has already loaded it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A dated decisions entry (2026-11-07 #1148) states what a strict choice keeps of a native-script word, with head notes on the 2026-10-30 file-strict and 2026-11-02 #1005 entries and the Standing lines pointing at it, so a Standing line no longer says what no entry says. The RFC's overview, its strict-hu and strict-ko sentences, its no-language refusal sentence and its operations-table row now say native-script words' readings; its File-strict paragraph's verb agrees again. The README's first-build sentence loads, not compiles, the reading index. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
decisions/README.md allows four kinds of edit to an entry, and "clarified by" is none of them; the 2026-10-30 entry's item 1 also says name readings leave. So the new entry SUPERSEDES both clauses in part, and the two heads say so in the sanctioned form. The entry names the filter as it was at 3j (strict_pool's) and since #1001 (strict_kept). The RFC's Status paragraph and phasing row get the same parenthetical as its overview, and strict hu's readings are the default's, a plain hu choice being refused. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1146 and #1147: the "native-script vocabulary" wording sweep #1147 listed, plus the findings of a post-merge review of its last fix commit (af7431c).
What changes
strict_keptkeeps a reading when its file is chosen, it ismul.toml's, or its word has a letter and no Latin letter, andchoosethen runs as under a plain choice. So a strict choice keeps a native-script word's readings, name readings included, exactly as a plain choice of the same languages keeps them: adefault = falsereading stays off unless its file is chosen. Strictptreadsगुरु प्रसाद शर्माtitleगुरु,ne.toml's given reading of it being off; strictnereads givenगुरु.Lexicon.strict's docstring,parser_for's docstring and its no-language refusal, theUNCHOOSABLEcomment, root AGENTS.md,mechanisms.md, decisions/vocabulary-model's Standing summary, and the vocabulary-model RFC. Dated decisions entries and the RFC's phasing row are left as written, as history.docs/customize.rstanddocs/AGENTS.mdsaid a word in another script keeps "every file's" readings, which thedefault = falsecase refutes.Dr. John Smith Jr.), the firstparser_for(locales.ES)took about 12 ms, not 37–43. The figures stand; the sentence now says the index is "about two thirds of the cost", "unless a parse has already loaded it".How it was checked
readings_ofunder a strict choice equals the plain choice's, forpt,ne,hi,ru,ja,koanden(0 mismatches). Strictenkeepsuk.toml's family reading ofпан.ruff,python -m doctest README.rst,sphinx-build -b doctestand-b html(no output), and the doc-citation, design-docs, rules and reading-index tests pass.Reviews
pr-review-toolkit:comment-analyzer, post-merge, on af7431c: 13 claims exact, 2 overbroad (the README first-build scope; "every file's" for a word in another script). Both fixed in 03f10ed, the first commit here, which also extended the qualifier to the sweep's own wording: adefault = falsereading stays off.pr-review-toolkit:comment-analyzeron 03f10ed: the claim holds over every tag alone and in pairs (0 differences). Two RFC sentences (verb agreement, the table row), the README's "compiles" for the index (it loads it), and RFC sites at the stricthu/kosentences and the no-language refusal. Fixed in b7d8c11.design-docs-revieweron 03f10ed: the RFC overview still had the old definition, and the Standing line said what no dated entry said. b7d8c11 added a dated 2026-11-07 Say what a strict choice keeps of a native-script word #1148 entry and the overview fix.design-docs-revieweron b7d8c11: "clarified by" is not an edit decisions/README.md allows, so the entry is now a partial supersession; it namedstrict_keptfor 3j, when the filter was thenstrict_pool's; the RFC's Status paragraph and 3j row, and stricthuread as the default's. Fixed in d83c3c8.design-docs-revieweron d83c3c8: no confirmed defects (stricthuequals the default's 293 native-script readings; quote verbatim; 3,240 choices, 0 differ). One low finding, the 3j head lacking the Say what a strict choice keeps of a native-script word #1148 note, fixed in the last commit, a one-clause addition checked by the doc tests.🤖 Generated with Claude Code