Repository navigation
Read a word with interior periods as a credential only where every chunk counts (#1131) - #1144
Merged
Merged
Conversation
…unk counts (#1131) A word with interior periods was a suffix where ANY chunk was suffix vocabulary, while brackets (rules/S1) and the period-less end of a name (rules/H5) read it more strictly, so the slots disagreed. Every chunk now counts, as the slash and hyphen joins already ask: a chunk counts as a suffix as written or is a member another chunk settles. A word the test refuses is read by position, as the shape is. - rules/S3: the every-chunk test (`period_joined_credential`); ASCII punctuation at a chunk's edge is no part of it; a glued honorific keeps its claim (J.씨); a suffix word that is also a name keeps none. - rules/S1: the same test sets a period-joined word apart in brackets, and one holding a member is a member, settled by S13's position. - rules/H5: a word every chunk of which is a title chains without a final period (John Smith Lt.Gov -> title). The title verdict in front of a name stays any-chunk (Dr.philol., Lt.Gen.). - en.toml: mch and bscmed listed; med, chb and bch refused with reasons. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ks once (#1131 review) - reads_as_initials asks the chunks of a word the periods join, as it asks a slash's: Justin (JP.MD) Stearns stays the nickname. - _period_chunks strips punctuation only beside a period, keeping the word's outer edges (John Smith [Msc.Ed] stays family), and the member test reads the same chunks. - Docs: the Lt.Gov limit moves into the trailing-title release bullet; rules/N3's Accepted, rules/S1's initials Except, decisions/H5's and decisions/S3's Standing lines, period_joined_vocab's docstring and a case note describe every chunk; the MD.3 move is recorded. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…second review) The first fix kept a word's outer punctuation only before its final period, so John Smith Msc.Ed.] read suffix and Msc.Ed] a name word. The outer edges now admit only the word's periods, a glued semicolon (rules/C10) and an ampersand joining the next credential, so Msc.Ed!, MD.PhD] and [Msc.Ed.] read as the name word MD! and MD/PhD] already are. A single letter before a glued honorific is the initial in S1's initials test, so Justin (J.씨) Stearns stays the nickname. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1131
A word with interior periods read as a suffix where ANY of its chunks was suffix vocabulary (v1's rule for
Lt.Gov.), while brackets (rules/S1) and the end of a name without a final period (rules/H5) read it more strictly, so the slots disagreed. Every chunk now counts, the test the slash and hyphen joins already ask (#1103, #1138).John Smith (Msc.Ed)Msc.EdJohn Smith (PhD, Msc.Ed)John (Msc.Ed) SmithJohn (MA/PhD) SmithisJohn Smith Lt.GovLt.GovLt.GovJohn Smith Bob.PhDsuffix-or-nameWhinnett, BM.BSJohn Smith Msc.Ed,JD.CPA,Lt.Gov.,J.씨,MD.&PhDJohn Smith Dr.PhD,St.John Smith,Dr.philol. …,Lt.Gen. …The rule
_vocab.period_joined_credential, sharing the joined reading's_memberand_settles). Punctuation beside an interior period is no part of a chunk (MD.&PhD); at the word's outer edges only its periods, a glued semicolon and an ampersand are, soMsc.Ed!reads as the name wordMD!andMD/PhD]already are. A word the test refuses is read by position, as the shape is.Justin (JP.MD) Stearnsstays the nickname), and one holding a member is a member, settled by rules/S13's position.Dr.philol.,Lt.Gen.,Dipl.-Kfm.,st.repr.andDut.ra Prof.raas given names (declined, decisions/S3).(Msc.Ed),John Smith Lt.Gov? #1131 entries.Vocabulary
mch(Master of Surgery, maskMCh) andbscmed. 92 ctgov-officials names written withMChmove, those that read reversed withMChthe given name (Abdul R Bhat, MCh) now reading it as the suffix.med(its mask would writeDr. MEd.into the GermanDr. med.),chbandbch(listed alone they stop rules/S12'sMB ChBmerging).Accepted
M.B., Ch.B.,M.Ed.,B.Ch) loses the chunk reading. Where it was already the suffix only the forced case view moves (M.Ed.→M.ED.undercapitalized(force=True)), and after a family comma alone it is the given name, reported.John Smith MD.3) is a name word, silently, asJohn Smith 1.4is.Measured (2026-11-07, against f86963a,
snapshot.py --local <source> --base <checkout>)John Smith Lt.Gov.MChnames, the rest the rule's own moves (Reva PROF.DR→ title, e-mail addresses glued into a name no longer the suffix,Sutriyo M.Si, Dr→ family, reported).जी.सी(G.C.) no longer a suffix in three.Review
Three rounds: a code review and a design-docs review of the first commit, then a review of the fix commit, which found that the first fix's edge strip read
Msc.Ed.]andMsc.Ed]differently andJustin (J.씨) Stearnsas the suffix; both fixed in the third commit. Suite passes on 3.11 and 3.15, serial tests included.🤖 Generated with Claude Code