Repository navigation
Add two Vietnamese local corpora: uit-vinames and vn-assembly - #1110
Merged
Merged
Conversation
uit-vinames: the 21,090 distinct full names of UIT-ViNames (To et al., NLPIR 2020), read from the authors' GitHub zip pinned by commit and sha256, written family name first with diacritics. vn-assembly: the 499 deputies of the 15th National Assembly from OpenSanctions' vn_national_assembly export (CC BY-NC 4.0), each name composed with the academic rank and degree its education states (PGS.TS., TS., ThS.). Neither source states a name's parts, so family, middle and given are derived by the Vietnamese convention (local_uit.split), versioned, and local_agreement.py scores both against them: the first local corpora whose middle names can be scored, which ORCID's two boxes cannot. vn-assembly's title box is scored, never set aside, and its groups (ethnicity) print from 10 records (GROUP_FLOORS). Adding the FIELDED rows leaves the other sources' scorer fingerprints unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…e group floor on Fielded, the highest rank, and the guards' tests Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two new local corpora of Vietnamese names, for measuring the Vietnamese pack proposed in #1108. As with the other local corpora, they are fetched into the cache and never committed.
What they are
uit-vinameslocal_uit.split, versioned bySPLIT_VERSION)vn-assemblyvn_national_assemblyexport (CC BY-NC 4.0)GS.TS., 9PGS.TS., 142TS., 241ThS., 100 untitled<title> <official name>, with the title read off the education the deputy states (title_of, versioned); the parts are derived by the same splitNeither source states the parts of a name, so the score measures agreement with the convention a reader assumes. For Kinh names that is the name's structure. For some other ethnicities' names (Ê-đê, for example) it is only position, and a score cannot see the difference.
vn-assemblykeeps the ethnicity so that its report can group by it.Changes
tools/differential/local_uit.pyandlocal_vnassembly.py, each registered inlocal_corpora.SOURCES.local_agreement.FIELDEDgains a row for each source, so both are scored on family, middle and given;vn-assemblyis scored on its title too, which is never set aside.Fieldedgains agroup_floorfield, sovn-assembly's ethnicity groups print from 10 records instead of 1,000. The field isrepr=False, soscorer_fingerprintis unchanged for the four existing sources:psc-individuals,orcid-researchers,patentsview-inventorsandcz-candidatesall match master.target_count. Lines are read withcorpus_build.jsonl_lines, and records are written through the sharedjsonl_line.tests/v2/test_local_uit.pyandtests/v2/test_local_vnassembly.py, offline, with invented names only.Scores on the corpora (2026-11-05)
local_agreement.py <source>under the default parser:uit-vinames13 of 21,090 agree,vn-assembly0 of 499. Both are expected, since both corpora are written family first. The scores of the #1108 pack go in that PR's decisions entry.Review
Reviewed by code-reviewer, pr-test-analyzer (37 mutations; the gaps it found are now covered: middle-only misses, the group floor, zero or two names, the boundary of the titled share), comment-analyzer, and a
/simplifypass with four angles. A second review round covered the fix commit.Skipped from
/simplify:urlopenstub in_differential_fixtures.py, which would touch test modules outside this change;🤖 Generated with Claude Code