Repository navigation
Link a lone letter after a connective, and join a connective with nothing to link to the word before it (#1097, #1098) - #1105
Merged
Conversation
…hing to link to the word before it (#1097, #1098) P3 makes two joins ahead of its three-word carve-out, in the part holding the family name: a single-letter connective in front of a lone letter ending the name words joins it to the word before, the letter being the second surname written as an initial (John Smith y V, Juan Garcia y L., Puig i V, Joan, the Catalan i included); and a connective with nothing but suffixes behind it joins the word before it alone (John Smith y III -> family 'Smith y', suffix 'III'). The #1093 exception that kept the generational i in the family part's count goes with it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…1098) - P13, a connective ending the name words, beside P6: both joins move out of P3, which points at it; decisions/P13 holds the record. - The end of the name is read under a given-first order only; the part before a family comma under every order. - A connective is never the lone letter (one-case and caseless names); a trailing title H5 reads no longer stops the walk; the join with nothing to link reads any connective written as a word, a symbol left out; a cased single letter ending a one-case name keeps its reading (local corpora: each such name an initial). - #1095's exception for a generational connective beside the numeral stays where P13 did not link the letter (Smith y i V, John). - Rows for each finding; the trailing_start arm and the frozen-link control rehomed; the property-test exemption narrowed to a letter ending its role. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…title to P3 (#1098) The second-round review found the rewrite had dropped the NFC fold, so a decomposed initial or connective read as on master, and that the widened join with nothing to link, past a trailing title, read couple formulas ('Mr. John Smith and Mrs.') as two titles. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…s and notes (#1097, #1098) - The couple-formula test reads the title standing right behind the word connective, not a title anywhere in the trailing run, so 'John Smith and Jr. Mrs.' joins as before the narrowing. - Case notes cite P13; history claims corrected (SMITH JONES Y JR., JOHN from 2.4.0; Smith y VI, John since #893). - P13: the one-case clause is on the Signal line as a case contrast; the lowercase and whole-name clauses say what the rule does. - Release log limits scoped (family-first without a comma; particles for the two-word count); decisions/S10 Standing keeps the exception. - decisions/P13's measurement re-run: committed corpora move two rule examples; local corpora over 38,349 names, the and/the/та/και added. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…, #1098) /simplify: the nested name_word and connective defs become module predicates, the lone-letter answer is read once, the couple test is named, docstrings trimmed to the citation. The NFC fold is _vocab's composed(), the per-token predicates keeping their inline fold (a call per token moved the link-run frame band). Behavior unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…-connective-before-numeral # Conflicts: # tests/v2/test_cases.py
Codecov's patch check found _is_lone_letter's multi-word arm unreached; 'John Smith y Ph. D.' reaches it, the credential group merged before the walk. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1097
Closes #1098
What moved
A new rule, P13 (a connective ending the name words), sits beside P6. It makes two joins before P3's three-word carve-out, in the part that holds the family name.
John Smith y VSmith, familyy, suffixVSmith y VJuan García y L.García y, familyL.García y L.Puig i V, JoanPuig V, suffixi(to 2.6.0); familyPuig, suffixi V(2.7.0 – 2.8.2)Puig i VJohn Smith y IIISmith, familyy, suffixIIISmith y, suffixIIIJohn Smith y VISmith y VISmith y, suffixVIJohn Paul Smith y IIISmith y IIISmith y, suffixIIIJohn Smith and Jr.Smith and Jr.Smith and, suffixJr.ias well.Decided in chat
JOHN SMITH Y V→ familySMITH Y V). A cased single letter ending a one-case name keeps its reading. Every such name in the local corpora is an initial:CHENG GUI Ykeeps familyY, and underFAMILY_FIRSTreads middleY.Boundaries (case rows)
Smith y VandDr. Smith y Vkeep the carve-out. Where the part is the whole name, the joins leave a word in front, so the name keeps its given name.Smith y i V, Johnkeeps suffixi V. This is a run of connectives. Count a family part's connectives out of its numeral count (#1093) #1095's S10 exception stays where P13 did not link the letter.Mr. John Smith and Mrs.stays a couple's formula. A word connective with a period-marked title right behind it is left to P3.John Smith and Jr. Mrs.still joinsSmith and.John Smith & IIIis unchanged. A symbol is no word.John Quincy Smith ikeeps suffixi. A generational connective with nothing after it stays the generation.John Smith Ykeeps familyY. A capital letter in a mixed-case name is an initial (P8).Rules amended
+ case contrast, which marks it a split candidate.Josep Carod i Rovirareads familyRovira— Catalan and Polish link surnames withi, which is not a conjunction #397 and Keep citation comments short: quote, clause, pointer #760), decisions/S10 (ShouldSmith y V, Johnkeep the V in the family name, asSmith Jones y V, Johndoes? #1093), decisions/C1, decisions/vocabulary-model and decisions/P9.Smith y V, Johnkeep the V in the family name, asSmith Jones y V, Johndoes? #1093 bullet's limits are scoped to particles.Yin a one-case name keeps its connective tag; only P8's marked letters read as initials.Measured
The recipe is in decisions/P13; the base is 27298ec.
Josep Lluis Carod i VandSmith i V, John.Lecouv e,Boll e,Bjerk y,B e. Each now keeps the surname whole.OF CHIPPEWA OF ND.Mr. and Mrs. John Smith). That cost is constant per name and moves no benchmark guard. Names without a connective pay nothing.Reviews
Each finding was fixed or recorded in the commit that follows it. The test review's mutants each fail a row, save the ones recorded as unreachable.
Checks
These pass:
uv run pytest,uv run pytest -n0 -m serial,uv run --python 3.15 pytest,uv run mypyanduv run ruff check.🤖 Generated with Claude Code