Skip to content

chore: Update for August 26 release - #63

Merged
nbaddam merged 3 commits into
mainfrom
august-26-update
Aug 5, 2026
Merged

nbaddam merged 3 commits into
mainfrom
august-26-update

Conversation

@nbaddam

@nbaddam nbaddam commented Aug 4, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Updates package to axe DevTools framework version 1.4.0.

This release of the axe DevTools framework (4.1.0) makes SupportsDynamicType
run automatically and it reports at CRITICAL impact. The
sample app uses fixed font sizes throughout, so every screen fails it and the existing
zero-critical check could never pass.

The check now allows that one rule by ID while still failing on anything else, so it
continues to demonstrate how you'd gate a build on accessibility. In your own app you'd
fix the fonts rather than allow the rule.

  • RegressionUITests.assertNoCriticalResults()
  • TargetedScanUITests.testHomeScreenHasNoCriticalIssues()

Also updated comments that referred to "the dashboard" to say DevHub, and clarified
where you can uncomment to post results.

Framework bump

Bumps the SPM dependency to 4.1.0.
Release: https://github.com/dequelabs/axe-devtools-ios/releases/tag/4.1.0

…uage in comments to reflect results posting to DevHub now
@nbaddam
nbaddam marked this pull request as ready for review August 4, 2026 21:34
Copilot AI review requested due to automatic review settings August 4, 2026 21:34

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the sample app’s UI tests to keep the “fail on CRITICAL accessibility issues” gate meaningful after the August axe DevTools release, by allowing the known CRITICAL SupportsDynamicType rule while still failing on any other unexpected CRITICAL results.

Changes:

  • Adjusted CRITICAL-gating assertions to allow SupportsDynamicType while still failing on other CRITICAL failures.
  • Refreshed test comments to refer to DevHub and clarified where to uncomment upload behavior.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
RegressionUITests/RegressionUITests.swift Allows a known CRITICAL rule while keeping the regression gate for unexpected CRITICAL issues; updates scan/upload comments.
axe-devtools-ios-sample-appUITests/TargetedScan/TargetedScanUITests.swift Updates targeted scan test messaging and gating to allow the known CRITICAL rule while failing on unexpected CRITICAL issues.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread RegressionUITests/RegressionUITests.swift Outdated
Comment thread axe-devtools-ios-sample-appUITests/TargetedScan/TargetedScanUITests.swift Outdated
Comment thread RegressionUITests/RegressionUITests.swift
nbaddam and others added 2 commits August 5, 2026 10:10
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@nbaddam nbaddam changed the title chore: Updating tests for August 26 release chore: Update for August 26 release Aug 5, 2026
@nbaddam
nbaddam merged commit d1b979c into main Aug 5, 2026
8 checks passed
@nbaddam
nbaddam deleted the august-26-update branch August 5, 2026 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants