Repository navigation
chore: Update for August 26 release - #63
Merged
Merged
Conversation
…uage in comments to reflect results posting to DevHub now
kyleleedq
approved these changes
Aug 4, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the sample app’s UI tests to keep the “fail on CRITICAL accessibility issues” gate meaningful after the August axe DevTools release, by allowing the known CRITICAL SupportsDynamicType rule while still failing on any other unexpected CRITICAL results.
Changes:
- Adjusted CRITICAL-gating assertions to allow
SupportsDynamicTypewhile still failing on other CRITICAL failures. - Refreshed test comments to refer to DevHub and clarified where to uncomment upload behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| RegressionUITests/RegressionUITests.swift | Allows a known CRITICAL rule while keeping the regression gate for unexpected CRITICAL issues; updates scan/upload comments. |
| axe-devtools-ios-sample-appUITests/TargetedScan/TargetedScanUITests.swift | Updates targeted scan test messaging and gating to allow the known CRITICAL rule while failing on unexpected CRITICAL issues. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
kyleleedq
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates package to axe DevTools framework version 1.4.0.
This release of the axe DevTools framework (
4.1.0) makes SupportsDynamicTyperun automatically and it reports at CRITICAL impact. The
sample app uses fixed font sizes throughout, so every screen fails it and the existing
zero-critical check could never pass.
The check now allows that one rule by ID while still failing on anything else, so it
continues to demonstrate how you'd gate a build on accessibility. In your own app you'd
fix the fonts rather than allow the rule.
RegressionUITests.assertNoCriticalResults()TargetedScanUITests.testHomeScreenHasNoCriticalIssues()Also updated comments that referred to "the dashboard" to say DevHub, and clarified
where you can uncomment to post results.
Framework bump
Bumps the SPM dependency to
4.1.0.Release: https://github.com/dequelabs/axe-devtools-ios/releases/tag/4.1.0