Repository navigation
fix(commons/dom): don't treat content of positioned containers as hidden by overflow - #5513
Open
Gillinghammer wants to merge 1 commit into
Open
Gillinghammer wants to merge 1 commit into
Gillinghammer wants to merge 1 commit into
Conversation
…den by overflow overflowHidden only looked at the position of the element itself. An element inside a position:absolute or position:fixed container that is placed outside an overflow:hidden ancestor was reported as hidden, even though the container is not clipped by that ancestor. Check every node between the element and the overflow ancestor instead. Closes: dequelabs#4539 Co-authored-by: Claude Code <noreply@toa.dev>
Contributor
|
Thanks for the pr. We have a lot of open prs at the moment so we'll try to get to this as soon as we can. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
overflowHiddenonly checked the position of the element itself, so an element inside aposition: absolute(orfixed) container that sits outside a staticoverflow: hiddenancestor was reported as hidden, even though the container isn't clipped by that ancestor. It now applies the existing escape rule (absolute with no positioned ancestor in between and a static overflow ancestor, or fixed) to every node between the element and the overflow ancestor. As before, other containing-block creators such astransformaren't considered.Added unit tests in
test/commons/dom/visibility-methods.jsandtest/commons/dom/is-visible-on-screen.js; the escaping cases fail without the change, andpnpm testpasses.Closes: #4539
AI disclosure: prepared autonomously with Claude Code (claude-opus-5-5) via TOA on behalf of @Gillinghammer, self-reviewed by the agent.
Tokens donated via TOA: about 501k