pass the job_id to the proxy too - #663
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused change is adequately tested, with no unresolved issues.
Review effort: Balanced
Findings: None
What changed in this PR
Passes DEPENDABOT_JOB_ID to the proxy to improve API request routing.
Changes:
- Uses the host job ID with a
clifallback. - Adds coverage for configured, empty, and unset values.
| File | Description |
|---|---|
internal/infra/proxy.go |
Forwards the job ID to the proxy. |
internal/infra/proxy_test.go |
Tests job ID propagation and fallback behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
jakecoffman
marked this pull request as ready for review
September 23, 2026 16:10
Nishnha
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Updater gets the Dependabot Job ID in this same way, pass it to the Proxy as well to match.
cli/internal/infra/updater.go
Line 315 in ba42140
This fixes issues where the Proxy doesn't know where to send some API requests.