Skip to content

perf: skip gzip for SEA responses by default - #1723

Merged
rahuls-db merged 1 commit into
mainfrom
rahul-singhal_data/rahul-singhal/sea-disable-response-gzip
Oct 6, 2026
Merged

rahuls-db merged 1 commit into
mainfrom
rahul-singhal_data/rahul-singhal/sea-disable-response-gzip

Conversation

@rahuls-db

Copy link
Copy Markdown
Collaborator

Description

Disables HTTP response compression by default for SQL Execution API requests by sending Accept-Encoding: identity. SEA inline results are already LZ4-compressed Arrow encoded in JSON, so the additional gzip layer adds server and client work.

The behavior is scoped to the SEA API client; OAuth, Thrift, CloudFetch, telemetry, and other HTTP traffic are unchanged. Bandwidth-constrained clients can restore the prior behavior with EnableSeaResponseCompression=1.

Testing

  • mvn -pl jdbc-core test -Dtest=DatabricksConnectionContextTest,DatabricksSdkClientUserAgentTest — 164 passed, 0 failed.
  • Spotless formatting ran successfully.
  • The complete jdbc-core suite was attempted, but the pre-existing DatabricksArrowPatchTest.testConcurrentExecution stress test did not complete after several minutes and was stopped; no failures occurred before that test.

Telemetry Errors

  • Not applicable — this PR does not add or change a telemetry-visible error.
  • Applicable — the error uses DatabricksDriverErrorCode where appropriate, and any new code is uniquely numbered and tested.
  • Applicable — its driver/server/user classification is linked, or maintainer help is requested because the author cannot access the classification.

Additional Notes to the Reviewer

This mirrors adbc-drivers/databricks#678 for the JDBC driver independent SEA implementation.

Signed-off-by: Rahul Singhal <rahul.singhal@databricks.com>
@rahuls-db
rahuls-db marked this pull request as ready for review October 6, 2026 18:07

@peco-review-bot peco-review-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No issues identified by the review bot.

@rahuls-db
rahuls-db requested a review from vuanhphung October 6, 2026 18:22
@rahuls-db
rahuls-db added this pull request to the merge queue Oct 6, 2026
Merged via the queue into main with commit d360baf Oct 6, 2026
29 checks passed
@rahuls-db
rahuls-db deleted the rahul-singhal_data/rahul-singhal/sea-disable-response-gzip branch October 6, 2026 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants