Repository navigation
[Backport release-1.19] fix: hold an actor's turn until a cancelled call finishes - #1878
Merged
Merged
Conversation
When a caller cancels an actor call while it runs, daprd releases the actor and sends the next call, but the SDK kept running the cancelled method, so two turns ran at once on the same actor. ActorManager now runs activation, method calls and deactivation through a per-actor turn lock. A turn keeps the actor until its code and the state save finish, even if its request is cancelled. Turns that are still waiting are dropped when cancelled. Fixes #1871 Signed-off-by: Javier Aliaga <javier@diagrid.io> (cherry picked from commit 47b9bb5)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-1.19 #1878 +/- ##
==================================================
+ Coverage 80.52% 80.60% +0.07%
- Complexity 2832 2847 +15
==================================================
Files 274 275 +1
Lines 8412 8459 +47
Branches 905 911 +6
==================================================
+ Hits 6774 6818 +44
- Misses 1270 1273 +3
Partials 368 368 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
javier-aliaga
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport 47b9bb5 from #1877.