Repository navigation
Conversation
Rajvira10
marked this pull request as ready for review
October 16, 2026 17:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With a descending domain whose first interval is collapsed,
scaleDiverging().domain([1, 1, 0])(0)returns0.5instead of1. Determine the direction from the transformed domain endpoints rather than the first interval, including when a power or symlog transform is reconfigured.Fixes #256.
Regression coverage includes the reported inputs, clamping, copying, a collapsed last interval, power and symlog reconfiguration, and positive and negative logarithmic domains. All four new tests fail against the original source and pass with this change.
Validation on Node 26.8.1:
yarn.lock(d3-array3.0.4,d3-format3.0.1,d3-time3.0.0).srcandtest: zero errors or warnings.git diff --check: passed.The installed Mocha 9 CLI's yargs dependency is incompatible with Node 26, so the suite was run through Mocha's programmatic API, with the same test glob and timezone as
npm test:The diff was independently reviewed and tested.